mirror of
https://github.com/fergalmoran/ladybird.git
synced 2026-01-08 01:27:31 +00:00
This patch makes two modifications to improve the behavior of cursors in editable DOM nodes, such as HTML tags with the contenteditable attribute. When the cursor blink cycle is reset in an editable DOM node, a repaint should be initiated. For this, set_needs_display() needs to be called on the layout node. Previously, the cursor blink cycle would not reset properly and moving the cursor with the arrow keys did not feel intuitive. Furthermore, this modifies one of the conditions necessary to actually paint the cursor, which previously prevented it from being painted when at the end of a text node, after all the text present.
301 lines
8.5 KiB
C++
301 lines
8.5 KiB
C++
/*
|
|
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/DOM/Document.h>
|
|
#include <LibWeb/DOM/Event.h>
|
|
#include <LibWeb/DOM/HTMLCollection.h>
|
|
#include <LibWeb/DOM/Window.h>
|
|
#include <LibWeb/HTML/HTMLAnchorElement.h>
|
|
#include <LibWeb/InProcessWebView.h>
|
|
#include <LibWeb/Layout/BreakNode.h>
|
|
#include <LibWeb/Layout/InitialContainingBlockBox.h>
|
|
#include <LibWeb/Layout/TextNode.h>
|
|
#include <LibWeb/Page/Frame.h>
|
|
#include <LibWeb/UIEvents/EventNames.h>
|
|
|
|
namespace Web {
|
|
|
|
Frame::Frame(DOM::Element& host_element, Frame& main_frame)
|
|
: m_page(*main_frame.page())
|
|
, m_main_frame(main_frame)
|
|
, m_loader(*this)
|
|
, m_event_handler({}, *this)
|
|
, m_host_element(host_element)
|
|
{
|
|
setup();
|
|
}
|
|
|
|
Frame::Frame(Page& page)
|
|
: m_page(page)
|
|
, m_main_frame(*this)
|
|
, m_loader(*this)
|
|
, m_event_handler({}, *this)
|
|
{
|
|
setup();
|
|
}
|
|
|
|
Frame::~Frame()
|
|
{
|
|
}
|
|
|
|
void Frame::setup()
|
|
{
|
|
m_cursor_blink_timer = Core::Timer::construct(500, [this] {
|
|
if (!is_focused_frame())
|
|
return;
|
|
if (m_cursor_position.node() && m_cursor_position.node()->layout_node()) {
|
|
m_cursor_blink_state = !m_cursor_blink_state;
|
|
m_cursor_position.node()->layout_node()->set_needs_display();
|
|
}
|
|
});
|
|
}
|
|
|
|
void Frame::did_edit(Badge<EditEventHandler>)
|
|
{
|
|
reset_cursor_blink_cycle();
|
|
}
|
|
|
|
void Frame::reset_cursor_blink_cycle()
|
|
{
|
|
m_cursor_blink_state = true;
|
|
m_cursor_blink_timer->restart();
|
|
m_cursor_position.node()->layout_node()->set_needs_display();
|
|
}
|
|
|
|
bool Frame::is_focused_frame() const
|
|
{
|
|
return m_page && &m_page->focused_frame() == this;
|
|
}
|
|
|
|
void Frame::set_document(DOM::Document* document)
|
|
{
|
|
if (m_document == document)
|
|
return;
|
|
|
|
m_cursor_position = {};
|
|
|
|
if (m_document)
|
|
m_document->detach_from_frame({}, *this);
|
|
|
|
m_document = document;
|
|
|
|
if (m_document) {
|
|
m_document->attach_to_frame({}, *this);
|
|
if (m_page && is_main_frame())
|
|
m_page->client().page_did_change_title(m_document->title());
|
|
}
|
|
|
|
if (m_page)
|
|
m_page->client().page_did_set_document_in_main_frame(m_document);
|
|
}
|
|
|
|
void Frame::set_viewport_rect(const Gfx::IntRect& rect)
|
|
{
|
|
bool did_change = false;
|
|
|
|
if (m_size != rect.size()) {
|
|
m_size = rect.size();
|
|
if (m_document) {
|
|
m_document->window().dispatch_event(DOM::Event::create(UIEvents::EventNames::resize));
|
|
m_document->update_layout();
|
|
}
|
|
did_change = true;
|
|
}
|
|
|
|
if (m_viewport_scroll_offset != rect.location()) {
|
|
m_viewport_scroll_offset = rect.location();
|
|
did_change = true;
|
|
}
|
|
|
|
if (did_change) {
|
|
for (auto* client : m_viewport_clients)
|
|
client->frame_did_set_viewport_rect(rect);
|
|
}
|
|
}
|
|
|
|
void Frame::set_size(const Gfx::IntSize& size)
|
|
{
|
|
if (m_size == size)
|
|
return;
|
|
m_size = size;
|
|
if (m_document) {
|
|
m_document->window().dispatch_event(DOM::Event::create(UIEvents::EventNames::resize));
|
|
m_document->update_layout();
|
|
}
|
|
|
|
for (auto* client : m_viewport_clients)
|
|
client->frame_did_set_viewport_rect(viewport_rect());
|
|
}
|
|
|
|
void Frame::set_viewport_scroll_offset(const Gfx::IntPoint& offset)
|
|
{
|
|
if (m_viewport_scroll_offset == offset)
|
|
return;
|
|
m_viewport_scroll_offset = offset;
|
|
|
|
for (auto* client : m_viewport_clients)
|
|
client->frame_did_set_viewport_rect(viewport_rect());
|
|
}
|
|
|
|
void Frame::set_needs_display(const Gfx::IntRect& rect)
|
|
{
|
|
if (!viewport_rect().intersects(rect))
|
|
return;
|
|
|
|
if (is_main_frame()) {
|
|
if (m_page)
|
|
m_page->client().page_did_invalidate(to_main_frame_rect(rect));
|
|
return;
|
|
}
|
|
|
|
if (host_element() && host_element()->layout_node())
|
|
host_element()->layout_node()->set_needs_display();
|
|
}
|
|
|
|
void Frame::scroll_to_anchor(const String& fragment)
|
|
{
|
|
if (!document())
|
|
return;
|
|
|
|
auto element = document()->get_element_by_id(fragment);
|
|
if (!element) {
|
|
auto candidates = document()->get_elements_by_name(fragment);
|
|
for (auto& candidate : candidates->collect_matching_elements()) {
|
|
if (is<HTML::HTMLAnchorElement>(*candidate)) {
|
|
element = downcast<HTML::HTMLAnchorElement>(*candidate);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
// FIXME: This is overly aggressive and should be something more like a "update_layout_if_needed()"
|
|
document()->force_layout();
|
|
|
|
if (!element || !element->layout_node())
|
|
return;
|
|
|
|
auto& layout_node = *element->layout_node();
|
|
|
|
Gfx::FloatRect float_rect { layout_node.box_type_agnostic_position(), { (float)viewport_rect().width(), (float)viewport_rect().height() } };
|
|
if (is<Layout::Box>(layout_node)) {
|
|
auto& layout_box = downcast<Layout::Box>(layout_node);
|
|
auto padding_box = layout_box.box_model().padding_box();
|
|
float_rect.translate_by(-padding_box.left, -padding_box.top);
|
|
}
|
|
|
|
if (m_page)
|
|
m_page->client().page_did_request_scroll_into_view(enclosing_int_rect(float_rect));
|
|
}
|
|
|
|
Gfx::IntRect Frame::to_main_frame_rect(const Gfx::IntRect& a_rect)
|
|
{
|
|
auto rect = a_rect;
|
|
rect.set_location(to_main_frame_position(a_rect.location()));
|
|
return rect;
|
|
}
|
|
|
|
Gfx::IntPoint Frame::to_main_frame_position(const Gfx::IntPoint& a_position)
|
|
{
|
|
auto position = a_position;
|
|
for (auto* ancestor = parent(); ancestor; ancestor = ancestor->parent()) {
|
|
if (ancestor->is_main_frame())
|
|
break;
|
|
if (!ancestor->host_element())
|
|
return {};
|
|
if (!ancestor->host_element()->layout_node())
|
|
return {};
|
|
position.translate_by(ancestor->host_element()->layout_node()->box_type_agnostic_position().to_type<int>());
|
|
}
|
|
return position;
|
|
}
|
|
|
|
void Frame::set_cursor_position(DOM::Position position)
|
|
{
|
|
if (m_cursor_position == position)
|
|
return;
|
|
|
|
if (m_cursor_position.node() && m_cursor_position.node()->layout_node())
|
|
m_cursor_position.node()->layout_node()->set_needs_display();
|
|
|
|
m_cursor_position = move(position);
|
|
|
|
if (m_cursor_position.node() && m_cursor_position.node()->layout_node())
|
|
m_cursor_position.node()->layout_node()->set_needs_display();
|
|
|
|
reset_cursor_blink_cycle();
|
|
}
|
|
|
|
String Frame::selected_text() const
|
|
{
|
|
StringBuilder builder;
|
|
if (!m_document)
|
|
return {};
|
|
auto* layout_root = m_document->layout_node();
|
|
if (!layout_root)
|
|
return {};
|
|
if (!layout_root->selection().is_valid())
|
|
return {};
|
|
|
|
auto selection = layout_root->selection().normalized();
|
|
|
|
if (selection.start().layout_node == selection.end().layout_node) {
|
|
if (!is<Layout::TextNode>(*selection.start().layout_node))
|
|
return "";
|
|
return downcast<Layout::TextNode>(*selection.start().layout_node).text_for_rendering().substring(selection.start().index_in_node, selection.end().index_in_node - selection.start().index_in_node);
|
|
}
|
|
|
|
// Start node
|
|
auto layout_node = selection.start().layout_node;
|
|
if (is<Layout::TextNode>(*layout_node)) {
|
|
auto& text = downcast<Layout::TextNode>(*layout_node).text_for_rendering();
|
|
builder.append(text.substring(selection.start().index_in_node, text.length() - selection.start().index_in_node));
|
|
}
|
|
|
|
// Middle nodes
|
|
layout_node = layout_node->next_in_pre_order();
|
|
while (layout_node && layout_node != selection.end().layout_node) {
|
|
if (is<Layout::TextNode>(*layout_node))
|
|
builder.append(downcast<Layout::TextNode>(*layout_node).text_for_rendering());
|
|
else if (is<Layout::BreakNode>(*layout_node) || is<Layout::BlockBox>(*layout_node))
|
|
builder.append('\n');
|
|
|
|
layout_node = layout_node->next_in_pre_order();
|
|
}
|
|
|
|
// End node
|
|
VERIFY(layout_node == selection.end().layout_node);
|
|
if (is<Layout::TextNode>(*layout_node)) {
|
|
auto& text = downcast<Layout::TextNode>(*layout_node).text_for_rendering();
|
|
builder.append(text.substring(0, selection.end().index_in_node));
|
|
}
|
|
|
|
return builder.to_string();
|
|
}
|
|
|
|
void Frame::register_viewport_client(ViewportClient& client)
|
|
{
|
|
auto result = m_viewport_clients.set(&client);
|
|
VERIFY(result == AK::HashSetResult::InsertedNewEntry);
|
|
}
|
|
|
|
void Frame::unregister_viewport_client(ViewportClient& client)
|
|
{
|
|
bool was_removed = m_viewport_clients.remove(&client);
|
|
VERIFY(was_removed);
|
|
}
|
|
|
|
void Frame::register_frame_nesting(URL const& url)
|
|
{
|
|
m_frame_nesting_levels.ensure(url)++;
|
|
}
|
|
|
|
bool Frame::is_frame_nesting_allowed(URL const& url) const
|
|
{
|
|
return m_frame_nesting_levels.get(url).value_or(0) < 3;
|
|
}
|
|
|
|
}
|