fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-08 09:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
3cb65645cfd682f32fee1271d2c7a710aff268fc
ladybird/Userland/Libraries/LibC
History
Sergey Bugaev b604640950 LibC: Fix struct declaration visibility 
Isn't

"expected struct timeval *, but argument is of type struct timeval *"

a fun error message? C considers a 'struct foo' mentioned inside a
function argument to be a distinct type from 'struct foo' declared on
the global level, but only if the in-function definition comes first. So
we need to ensure that struct timeval is declared (either fully, or
forward-declared) before we declare select() and pselect(). This was
taken care of by including <sys/time.h>, but
https://github.com/SerenityOS/serenity/pull/20044 made it so that
<sys/time.h> itself includes <sys/select.h>. So if the user's program
includes <sys/time.h> (before possibly including <sys/select.h>), then
<sys/select.h>'s include of <sys/time.h> will turn into a no-op (since
<sys/time.h> is already being included), yet there will not have been a
struct timeval definition yet, and we'd get the fun error message.

Fix this by including <Kernel/API/POSIX/sys/time.h> instead of
<sys/time.h>
2023-07-29 16:51:58 -06:00
..
arch
LibC: Remove i686 support
2022-12-28 11:53:41 +01:00
arpa
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
bits
LibC: Make getopt available from getopt.h
2023-07-19 00:19:35 -06:00
net
…
netinet
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
sys
LibC: Fix struct declaration visibility
2023-07-29 16:51:58 -06:00
alloca.h
…
assert.cpp
Kernel: Move process coredump metadata modification to the prctl syscall
2023-03-05 16:55:08 +01:00
assert.h
Everywhere: Run clang-format
2022-12-03 23:52:23 +00:00
byteswap.h
…
CMakeLists.txt
Everywhere: Resolve conflicts with LibC and libc++
2023-06-27 12:40:38 +02:00
complex.h
LibC: Fix duplicated function symbols
2023-07-29 16:51:58 -06:00
crt0_shared.cpp
Everywhere: Remove unused includes of LibC/stdlib.h
2023-01-02 20:27:20 -05:00
crt0.cpp
LibC: Set up a dummy first stack frame in _start
2023-06-01 09:04:20 +02:00
ctype.cpp
…
ctype.h
…
cxxabi.cpp
Everywhere: Remove "LibC/" includes, add lint-rule against it
2023-01-07 10:01:37 -07:00
dirent.cpp
Everywhere: Remove unused includes of AK/Format.h
2023-01-02 20:27:20 -05:00
dirent.h
LibC: Add missing sys/cdefs.h include
2022-08-23 19:07:12 +01:00
dlfcn.cpp
Userland: Fix wrong signature of dladdr
2023-05-05 02:19:05 +02:00
dlfcn.h
Userland: Fix wrong signature of dladdr
2023-05-05 02:19:05 +02:00
elf.h
LibC+LibELF: Move ELF definitions from LibC to LibELF
2023-06-27 12:40:38 +02:00
endian.h
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
errno_codes.h
…
errno.h
LibC: Implement errno via a __errno_location() function
2022-04-21 11:49:48 +02:00
fcntl.cpp
LibC: Properly implement the futimens function
2023-04-10 10:21:28 +02:00
fcntl.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
fd_set.h
Kernel+LibC: Move the FD_SETSIZE declaration to API/POSIX/select.h file
2023-03-01 19:36:53 -07:00
fenv.cpp
Everywhere: Use ARCH(AARCH64) instead of AK_ARCH_AARCH64
2023-04-14 19:15:19 +02:00
fenv.h
…
float.h
…
fnmatch.cpp
Everywhere: Fix more Copyright header inconsistencies
2021-10-04 11:10:09 +01:00
fnmatch.h
LibC: Add missing sys/cdefs.h include
2022-08-23 19:07:12 +01:00
getopt.cpp
LibC: Correctly reset the getopt state on optind = 1
2023-03-12 22:09:09 +01:00
getopt.h
LibC: Make getopt available from getopt.h
2023-07-19 00:19:35 -06:00
getsubopt.cpp
Everywhere: Remove unused includes of LibC/stdlib.h
2023-01-02 20:27:20 -05:00
glob.cpp
LibC: Add stubs for glob and globfree
2022-07-08 22:27:38 +00:00
glob.h
…
grp.cpp
LibC: Ensure that struct group::gr_mem pointers are aligned
2023-05-28 05:05:09 -06:00
grp.h
LibC: Implement getgrent_r
2022-11-25 23:13:16 +01:00
ifaddrs.cpp
Everywhere: Remove "LibC/" includes, add lint-rule against it
2023-01-07 10:01:37 -07:00
ifaddrs.h
…
inttypes.cpp
…
inttypes.h
Kernel+Userland: Remove uses of the __i386__ compiler macro
2022-12-28 11:53:41 +01:00
ioctl.cpp
LibC: Don't truncate arguments for ioctl() on x86_64
2021-07-22 04:18:39 +04:30
langinfo.cpp
Everywhere: Run clang-format
2022-04-01 21:24:45 +01:00
langinfo.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
libcinit.cpp
LibC: Implement errno via a __errno_location() function
2022-04-21 11:49:48 +02:00
libgen.cpp
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
libgen.h
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
limits.h
LibC: Fix max value of short
2023-07-08 15:53:02 -04:00
link.cpp
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
link.h
…
locale.cpp
…
locale.h
…
malloc.cpp
Kernel+Libraries: Move defines and types from sys/auxv.h to Kernel/API
2023-01-21 10:43:59 -07:00
mallocdefs.h
…
math.cpp
Everywhere: Use ARCH(AARCH64) instead of AK_ARCH_AARCH64
2023-04-14 19:15:19 +02:00
math.h
LibM: Move the math standard library to LibC
2022-09-16 16:09:19 +00:00
memory.h
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
mntent.cpp
LibC: Remove TODO() macros to not break mc port
2022-01-13 18:46:22 +01:00
mntent.h
…
net.cpp
LibC: Implement if_indextoname and if_nametoindex
2023-04-14 12:29:03 +01:00
netdb.cpp
LibIPC+LibC: Add and use a helper to encode/decoder container sizes
2023-01-04 20:13:54 +01:00
netdb.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
nl_types.h
…
paths.h
Ports: Add lowdown 1.0.2
2023-06-07 13:44:44 +02:00
poll.cpp
LibC: Mark a bunch of functions as cancellation points
2022-07-22 10:07:15 -07:00
poll.h
LibC: Add missing sys/cdefs.h include
2022-08-23 19:07:12 +01:00
priority.cpp
LibC: Add getpriority() and setpriority() stubs
2021-09-23 18:51:21 +02:00
pthread_cond.cpp
LibC: Mark a bunch of functions as cancellation points
2022-07-22 10:07:15 -07:00
pthread_integration.cpp
Kernel: Clean up sys$futex and add support for cross-process futexes
2022-07-21 16:39:22 +02:00
pthread_once.cpp
Kernel: Clean up sys$futex and add support for cross-process futexes
2022-07-21 16:39:22 +02:00
pthread_tls.cpp
LibC: Remove a bunch of weak pthread_* symbols
2022-07-19 20:58:51 -07:00
pthread.cpp
Kernel+LibC: Implement pthread_create for AArch64
2023-04-23 14:30:59 +02:00
pthread.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
pty.cpp
Everywhere: Remove unused includes of AK/Format.h
2023-01-02 20:27:20 -05:00
pty.h
LibC: Remove 'int* aslave' parameter from forkpty()
2021-05-06 13:52:46 +01:00
pwd.cpp
Everywhere: Remove unused DeprecatedString includes
2023-04-09 22:00:54 +02:00
pwd.h
…
qsort.cpp
Everywhere: Run clang-format
2022-04-01 21:24:45 +01:00
regex.cpp
LibC: Reduce reliance on the dlfcn internals for regex functions
2022-09-05 10:12:02 +01:00
regex.h
LibC+LibRegex: Move regex_defs.h from LibC to LibRegex
2023-06-27 12:40:38 +02:00
resolv.cpp
…
resolv.h
…
scanf.cpp
Everywhere: Remove unused includes of AK/StdLibExtras.h
2023-01-02 20:27:20 -05:00
sched.cpp
…
sched.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
search.cpp
Everywhere: Run clang-format
2022-04-01 21:24:45 +01:00
search.h
…
semaphore.cpp
LibC: Convert semaphore and termcap to String
2023-07-06 10:15:37 +01:00
semaphore.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
serenity.cpp
Kernel+LibC: Implement readlinkat(2)
2022-12-11 19:55:37 -07:00
serenity.h
…
setjmp.h
Kernel+Userland: Remove uses of the __i386__ compiler macro
2022-12-28 11:53:41 +01:00
shadow.cpp
Everywhere: Remove unused includes of LibC/stdlib.h
2023-01-02 20:27:20 -05:00
shadow.h
…
signal.cpp
LibC: Ignore signals that don't have a name in getsignalbyname()
2023-06-07 00:24:09 +02:00
signal.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
spawn.cpp
Everywhere: Remove unused includes of LibC/stdlib.h
2023-01-02 20:27:20 -05:00
spawn.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
ssp_nonshared.cpp
LibC: Properly implement stack protectors
2022-11-01 14:49:09 +00:00
ssp.cpp
LibELF: Add stack guard hardening
2022-11-29 11:04:21 +01:00
stat.cpp
LibC: Properly implement the futimens function
2023-04-10 10:21:28 +02:00
stdarg.h
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
stdint.h
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
stdio_ext.h
LibC: Add missing sys/cdefs.h include
2022-08-23 19:07:12 +01:00
stdio.cpp
Revert "LibC: Remove duplicate log statement"
2023-07-22 12:19:53 -04:00
stdio.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
stdlib.cpp
Everywhere: Remove needless trailing semi-colons after functions
2023-07-08 10:32:56 +01:00
stdlib.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
string.cpp
LibC: Relax memmove() to memcpy() in more cases
2023-07-07 23:46:54 +02:00
string.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
strings.cpp
LibC: Add ffs{,l,ll}
2022-10-14 13:37:29 +02:00
strings.h
…
stubs.cpp
Everywhere: Run clang-format
2022-12-03 23:52:23 +00:00
sysexits.h
…
syslog.cpp
AK: Remove StringBuilder::build() in favor of to_deprecated_string()
2023-01-27 20:38:49 +00:00
syslog.h
Everywhere: Run clang-format
2022-04-01 21:24:45 +01:00
termcap.cpp
LibC: Convert semaphore and termcap to String
2023-07-06 10:15:37 +01:00
termcap.h
…
termios.cpp
LibC: Mark a bunch of functions as cancellation points
2022-07-22 10:07:15 -07:00
termios.h
…
time.cpp
AK+LibC: Remove AK/Atomic.h includes from our RefPtrs
2023-07-04 16:30:13 +02:00
time.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
times.cpp
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
ucontext.h
…
ulimit.cpp
LibC: Add a wrapper for the getrusage syscall
2022-02-28 20:09:37 +01:00
ulimit.h
…
unistd.cpp
Kernel+LibCore+LibC: Split the mount syscall into multiple syscalls
2023-07-02 01:04:51 +02:00
unistd.h
LibC: Make getopt available from getopt.h
2023-07-19 00:19:35 -06:00
utime.cpp
Everywhere: Run clang-format
2022-04-01 21:24:45 +01:00
utime.h
…
utmp.h
…
utsname.cpp
Everything: Move to SPDX license identifiers in all files.
2021-04-22 11:22:27 +02:00
wchar.cpp
LibC: Implement wcswidth
2022-06-30 11:57:49 +02:00
wchar.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
wctype.cpp
Everywhere: Remove unused includes of AK/Format.h
2023-01-02 20:27:20 -05:00
wctype.h
LibC: Add most of the "header may make visible" dependencies from POSIX
2023-07-19 00:19:35 -06:00
wstdio.cpp
LibC: Automatically append null terminator in vswprintf
2022-03-20 08:40:36 -04:00