mirror of
https://github.com/fergalmoran/ladybird.git
synced 2025-12-25 10:48:41 +00:00
932a722623
Previously, the actual behavior of magic lookup and one described in its commit description have not matched. Instead of being weak definitions in a library that is always in the end of load order, the definitions were normal ones and thus were able to override other weak definitions in LibC. While this was consistent with how DynamicLoader resolves ambiguity between normal and weak relocations, this is not the behavior POSIX mandates -- we should always choose first available definition wrt load order. To fix this problem, the patch makes sure we don't define any of magic symbols in LibC. In addition to this, it makes all provided magic symbols functions (instead of objects), what renders MagicWeakSymbol class unnecessary.
29 lines
618 B
C
29 lines
618 B
C
/*
|
|
* Copyright (c) 2021, Gunnar Beutner <gunnar@beutner.name>
|
|
* Copyright (c) 2022, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/ByteString.h>
|
|
#include <AK/Result.h>
|
|
|
|
struct DlErrorMessage {
|
|
DlErrorMessage(ByteString&& other)
|
|
: text(move(other))
|
|
{
|
|
}
|
|
|
|
// The virtual destructor is required because we're passing this
|
|
// struct to the dynamic loader - whose operator delete differs
|
|
// from the one in libc.so
|
|
virtual ~DlErrorMessage() = default;
|
|
|
|
ByteString text;
|
|
};
|
|
|
|
struct __Dl_info;
|
|
typedef struct __Dl_info Dl_info;
|