Shannon Booth 6cac2981fb LibURL: Fail parsing IPV4 URLs starting with 0x that overflow ...

Parsing last as an IPV4 number was not returning true in "ends with a
number" as the parsing of that part was overflowing. This means that the
URL is not considered to be an IPv4 address, and is treated as a valid
domain.

Helpfully, the spec also points out in a note that this step is
equivalent to simply checking that the last part ends with 0x followed
by only hex digits - which doesn't suffer from any overflow problem!

Arguably this is an editorial issue in the spec where this should be
clarified a little bit. But for now, fixing this fixes 3 sub tests in
WPT for:

https://wpt.live/url/url-constructor.any.html

2024-08-06 23:08:12 +01:00

..

invalid-urls.html

LibURL: Fail parsing IPV4 URLs starting with 0x that overflow

2024-08-06 23:08:12 +01:00

strip_trailing_spaces_from_opaque_path.html

LibWeb/URL: Add strip_trailing_spaces_from_an_opaque_path()

2023-09-15 11:15:43 -06:00

url.html

LibWeb: Don't strip leading '?' in query initializing a URL

2024-08-06 23:08:12 +01:00