fergalmoran/ladybird
1
0
Fork 0
mirror of https://github.com/fergalmoran/ladybird.git synced 2026-01-02 14:48:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
5ec76331e8dc5080abe547550b0bcad5e91e27c4
ladybird/Userland/Libraries/LibWeb/DOM
History
Timothy Flynn 5ec76331e8 LibWeb: Invoke our internal attribute change handler from Attr 
Currently, every public DOM::Element method which changes an attribute
fires this handler itself. This was missed in commit 720f7ba, so any
user of that API would not fire the internal handler.

To fix this, and prevent any missing invocations in the future, invoke
the handler from from Attr::handle_attribute_changes. This method is
reached for all attribute changes, including adding/removing attributes.
This ensures the handler will always be fired, and reduces the footprint
of this ad-hoc behavior.

Note that our ad-hoc handler is not the "attribute change steps" noted
by the spec. Those are overridden only by a couple of specific elements,
e.g. HTMLSlotElement. However, we could easily make our ad-hoc handler
hook into those steps in the future.
2023-09-02 13:55:32 -04:00
..
AbortController.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
AbortController.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
AbortController.idl
…
AbortSignal.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
AbortSignal.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
AbortSignal.idl
…
AbstractRange.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
AbstractRange.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
AbstractRange.idl
…
AccessibilityTreeNode.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
AccessibilityTreeNode.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
Attr.cpp
LibWeb: Invoke our internal attribute change handler from Attr
2023-09-02 13:55:32 -04:00
Attr.h
LibWeb: Extract changing an attribute to its own method
2023-09-02 01:46:37 +03:30
Attr.idl
…
CDATASection.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
CDATASection.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
CDATASection.idl
…
CharacterData.cpp
LibWeb: Invalidate layout-transformed text on DOM text node change
2023-08-16 12:16:05 +02:00
CharacterData.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
CharacterData.idl
…
ChildNode.h
…
ChildNode.idl
…
Comment.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
Comment.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
Comment.idl
…
CustomEvent.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
CustomEvent.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
CustomEvent.idl
…
Document.cpp
LibWeb: Fix int parsing in Document::shared_declarative_refresh_steps
2023-08-31 22:27:48 +01:00
Document.h
LibWeb: Implement snapshotting source snapshot params per the spec
2023-08-28 09:47:11 +02:00
Document.idl
…
DocumentFragment.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
DocumentFragment.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
DocumentFragment.idl
…
DocumentLoadEventDelayer.cpp
…
DocumentLoadEventDelayer.h
…
DocumentLoading.cpp
LibWeb: Make Fetch::Infrastructure::Body be GC allocated
2023-08-19 15:12:00 +02:00
DocumentLoading.h
…
DocumentObserver.cpp
…
DocumentObserver.h
LibWeb: Rename loaded observer event to match spec
2023-07-12 13:16:23 +02:00
DocumentType.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
DocumentType.h
LibWeb: Port DocumentType from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DocumentType.idl
LibWeb: Port DocumentType from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMEventListener.cpp
…
DOMEventListener.h
…
DOMImplementation.cpp
LibWeb: Port DocumentType from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMImplementation.h
LibWeb: Port DOMImplementation from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMImplementation.idl
LibWeb: Port DOMImplementation from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMTokenList.cpp
LibWeb: Port DOMTokenList from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMTokenList.h
LibWeb: Port DOMTokenList from DeprecatedString to String
2023-08-27 05:34:54 +02:00
DOMTokenList.idl
LibWeb: Port DOMTokenList from DeprecatedString to String
2023-08-27 05:34:54 +02:00
Element.cpp
LibWeb: Invoke our internal attribute change handler from Attr
2023-09-02 13:55:32 -04:00
Element.h
LibWeb: Invoke our internal attribute change handler from Attr
2023-09-02 13:55:32 -04:00
Element.idl
LibWeb: Implement Element.hasAttributeNS
2023-08-09 22:10:58 -04:00
ElementFactory.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
ElementFactory.h
…
Event.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
Event.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
Event.idl
…
EventDispatcher.cpp
…
EventDispatcher.h
…
EventHandler.idl
…
EventTarget.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
EventTarget.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
EventTarget.idl
…
HTMLCollection.cpp
LibWeb: Port HTMLCollection from DeprecatedString to String
2023-08-27 05:34:54 +02:00
HTMLCollection.h
LibWeb: Port HTMLCollection from DeprecatedString to String
2023-08-27 05:34:54 +02:00
HTMLCollection.idl
LibWeb: Port HTMLCollection from DeprecatedString to String
2023-08-27 05:34:54 +02:00
HTMLFormControlsCollection.cpp
LibWeb: Implement HTMLFormControlsCollection
2023-08-20 11:04:03 +02:00
HTMLFormControlsCollection.h
LibWeb: Implement HTMLFormControlsCollection
2023-08-20 11:04:03 +02:00
HTMLFormControlsCollection.idl
LibWeb: Implement HTMLFormControlsCollection
2023-08-20 11:04:03 +02:00
IDLEventListener.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
IDLEventListener.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
InnerHTML.idl
…
LiveNodeList.cpp
LibWeb: Implement LiveNodeList::first_matching
2023-08-26 13:51:18 +02:00
LiveNodeList.h
LibWeb: Implement LiveNodeList::first_matching
2023-08-26 13:51:18 +02:00
MutationObserver.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
MutationObserver.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
MutationObserver.idl
…
MutationRecord.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
MutationRecord.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
MutationRecord.idl
…
MutationType.cpp
AK: Make "foo"_fly_string infallible
2023-08-07 16:03:27 +02:00
MutationType.h
AK: Make "foo"_fly_string infallible
2023-08-07 16:03:27 +02:00
NamedNodeMap.cpp
LibWeb: Handle attribute changes after actually changing the attribute
2023-09-02 13:55:32 -04:00
NamedNodeMap.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
NamedNodeMap.idl
…
Node.cpp
LibWeb: Remove unnecessary layout node detach in DOM::Node::finalize()
2023-08-28 23:36:22 +02:00
Node.h
LibWeb: Never blockify HTML <br> elements
2023-09-01 12:45:38 +02:00
Node.idl
…
NodeFilter.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
NodeFilter.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
NodeFilter.idl
…
NodeIterator.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
NodeIterator.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
NodeIterator.idl
…
NodeList.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
NodeList.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
NodeList.idl
…
NodeOperations.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
NodeOperations.h
…
NonDocumentTypeChildNode.h
…
NonElementParentNode.h
…
ParentNode.cpp
LibWeb: Cache lowercased tag name for getElementsByTagName() iteration
2023-08-23 08:06:25 +02:00
ParentNode.h
…
ParentNode.idl
…
Position.cpp
…
Position.h
…
ProcessingInstruction.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
ProcessingInstruction.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
ProcessingInstruction.idl
…
QualifiedName.cpp
…
QualifiedName.h
LibWeb: Cache lowercased tag name for getElementsByTagName() iteration
2023-08-23 08:06:25 +02:00
RadioNodeList.cpp
LibWeb: Implement value attribute of RadioNodeList
2023-08-26 13:51:18 +02:00
RadioNodeList.h
LibWeb: Implement value attribute of RadioNodeList
2023-08-26 13:51:18 +02:00
RadioNodeList.idl
LibWeb: Implement value attribute of RadioNodeList
2023-08-26 13:51:18 +02:00
Range.cpp
LibWeb: Port Range interface from DeprecatedString to String
2023-08-29 10:05:02 +02:00
Range.h
LibWeb: Port Range interface from DeprecatedString to String
2023-08-29 10:05:02 +02:00
Range.idl
LibWeb: Port History interface from DeprecatedString to String
2023-08-29 10:05:02 +02:00
ShadowRoot.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
ShadowRoot.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
ShadowRoot.idl
…
StaticNodeList.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
StaticNodeList.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
StaticRange.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
StaticRange.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
StaticRange.idl
…
StyleElementUtils.cpp
LibWeb: Don't parse inline style sheets during HTML fragment parsing
2023-08-09 17:09:28 +02:00
StyleElementUtils.h
…
Text.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
Text.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
Text.idl
…
TreeWalker.cpp
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
TreeWalker.h
LibJS: Make Heap::allocate<T>() infallible
2023-08-13 15:38:42 +02:00
TreeWalker.idl
…
XMLDocument.cpp
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
XMLDocument.h
LibJS: Make Cell::initialize() return void
2023-08-08 07:39:11 +02:00
XMLDocument.idl
…