39af1f8519
The current version of our Python port (3.6.0) is over four years old by now and has (or had, I haven't actually tried it in a while) some limitations - time for an upgrade! The latest Python release is 3.9.1, so I used that version. It's a from-scratch port, no patches are taken from the previous port to ensure the smallest possible amount of code is patched. The BuildPython.sh script is useful so I kept it, with some tweaks. I added a short document explaining each patch to ease judging their underlying problem and necessity in the future. Compared to the old Python port, this one does support both the time module as well as threading (at least _thread) just fine. Importing modules written in C (everything in /usr/local/lib/python3.9/lib-dynload) currently asserts in Serenity's dynamic loader, which is unfortunate but probably solvable. Possibly related to #4642. I didn't try building Python statically, which might be one possibility to circumvent this issue. I also renamed the directory to just "python3", which is analogous to the Python 3.x package most Linux distributions provide. That implicitly means that we likely will not support multiple versions of the Python port at any given time, but again, neither do many other systems by default. Recent versions are usually backwards compatible anyway though, so having the latest shouldn't be a problem. On the other hand bumping the version should now be be as simple as updating the variables in version.sh, given that no new patches are required. These core modules to currently not build - I chose to ignore that for now rather than adding more patches to make them work somehow, which means they're fully unavailable. This should probably be fixed in Serenity itself. _ctypes, _decimal, _socket, mmap, resource, termios These optional modules requiring 3rd-party dependencies do currently not build (even with depends="ncurses openssl zlib"). Especially the absence of a readline port makes the REPL a bit painful to use. :^) _bz2, _curses, _curses_panel, _dbm, _gdbm, _hashlib, _lzma, _sqlite3, _ssl, _tkinter, _uuid, nis, ossaudiodev, readline, spwd, zlib I did some work on LibC and LibM beforehand to add at least stubs of missing required functions, it still encounters an ASSERT_NOT_REACHED() / TODO() every now and then, notably frexp() (implementations of that can be found online easily if you want to get that working right now). But then again that's our fault and not this port's. :^)
Patches for Python 3.9 on SerenityOS
define-have-sigset-t.patch
Ensures HAVE_SIGSET_T is defined, as we do have sigset_t but it's not detected properly due to some related functions being missing.
define-py-force-utf8-locale.patch
Enforce UTF-8 as encoding by defining _Py_FORCE_UTF8_LOCALE.
disable-setrlimit.patch
Disables check for RLIMIT_CORE and subsequent setrlimit() call. Would be enabled otherwise as we do have <sys/resource.h> and therefore HAVE_SYS_RESOURCE_H.
fix-autoconf.patch
As usual, make the configure script recognize Serenity.
fix-hidden-symbol-referenced-by-dso.patch
Fix a weird build issue of python and other provided binaries by marking the main() functions Py_EXPORTED_SYMBOL.
hidden symbol `main' in Programs/python.o is referenced by DSO
Not sure what the proper fix for this is, but it works fine.
remove-setlocale-from-preconfig.patch
Our stub implementation of setlocale() always returns nullptr, which the interpreter considers critical enough to exit right away.
tweak-unsupported-printf-format-specifiers.patch
Replace uses of %.Ns with %s as the former is not supported by our printf implementation yet and would result in empty strings. It uses snprintf already, so this is safe.
use-rtld-lazy-for-dlopenflags.patch
We have RTLD_NOW defined but don't actually support it, so use the provided RTLD_LAZY fallback. Doesn't help the dynamic library module import assertion though.