From b0dcadeebb55f30aa704af1e5f565a13f40adad9 Mon Sep 17 00:00:00 2001 From: Luke Watts Date: Sat, 30 Sep 2023 15:49:36 +0200 Subject: [PATCH] feat: upgrade project to run node v20 --- .circleci/config.yml | 4 ++-- .gitpod.yml | 2 +- .node-version | 2 +- .nvmrc | 1 - CONTRIBUTING.md | 2 +- functions/package.json | 4 ++-- package.json | 4 ++-- .../documentation/docs/Getting Started/setup.md | 2 +- scripts/envCheck.js | 4 ++-- yarn.lock | 13 ++++++++++--- 10 files changed, 22 insertions(+), 16 deletions(-) delete mode 100644 .nvmrc diff --git a/.circleci/config.yml b/.circleci/config.yml index 0b2c32e4e..42aa83972 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -27,7 +27,7 @@ aliases: # use a base image running node v18 with chrome/firefox browsers preinstalled # This can be applied to any job via `docker: *docker` syntax - &docker - - image: cimg/node:18.17.1-browsers + - image: cimg/node:20.7.0-browsers # Use base image with support for node version parameter and matrix # This can be applied to any job via `<<: *docker_matrix` syntax @@ -35,7 +35,7 @@ aliases: parameters: node-version: type: string - default: 18.17.1-browsers + default: 20.7.0-browsers docker: - image: cimg/node:<< parameters.node-version >> diff --git a/.gitpod.yml b/.gitpod.yml index 73dcde1c6..6462a057a 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -1,4 +1,4 @@ -image: node:18 +image: node:20 tasks: - init: yarn install && yarn run build command: yarn run start diff --git a/.node-version b/.node-version index 4a1f488b6..3d3254308 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -18.17.1 +20.8.0 diff --git a/.nvmrc b/.nvmrc deleted file mode 100644 index 25bf17fc5..000000000 --- a/.nvmrc +++ /dev/null @@ -1 +0,0 @@ -18 \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8f27ff13a..df7368fa0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -27,7 +27,7 @@ This project and everyone participating in it is governed by the [Code of Conduc **Prerequisites** -- [Node.js v18](https://nodejs.org/en/download/) +- [Node.js v20](https://nodejs.org/en/download/) - [Yarn v3](https://yarnpkg.com/getting-started/install) With the above tools available, you are ready: diff --git a/functions/package.json b/functions/package.json index 0050ee588..582a89fee 100644 --- a/functions/package.json +++ b/functions/package.json @@ -48,7 +48,7 @@ "@types/dateformat": "^3.0.1", "@types/fs-extra": "^9.0.2", "@types/jest": "^29.2.0", - "@types/node": "18", + "@types/node": "^20.8.0", "@types/request": "^2.48.5", "@types/uuid": "^9.0.0", "@types/webpack": "^5.28.0", @@ -70,7 +70,7 @@ "webpack-node-externals": "^3.0.0" }, "engines": { - "node": "18" + "node": "20" }, "private": true } diff --git a/package.json b/package.json index 528ef00a7..6490769c0 100644 --- a/package.json +++ b/package.json @@ -140,7 +140,7 @@ "@types/browser-image-compression": "^1.0.9", "@types/flux-standard-action": "1.1.0", "@types/jest": "^27.4.1", - "@types/node": "18", + "@types/node": "^20.8.0", "@types/pubsub-js": "^1.5.18", "@types/react": "17.0.2", "@types/react-dom": "17.0.2", @@ -211,7 +211,7 @@ }, "engines": { "npm": "please-use-yarn", - "node": ">=18.17.1 <19.0.0" + "node": ">=20" }, "packageManager": "yarn@3.6.3" } diff --git a/packages/documentation/docs/Getting Started/setup.md b/packages/documentation/docs/Getting Started/setup.md index b5f586ee2..7e47b8b61 100644 --- a/packages/documentation/docs/Getting Started/setup.md +++ b/packages/documentation/docs/Getting Started/setup.md @@ -14,7 +14,7 @@ title: Local Setup This will be used to run the local server. It included the `npm` package manager :::tip - The recommended version of node to use is **node 18** as this is what also runs in the production environment. If running a higher version and experiencing issues please file a bug report. + The recommended version of node to use is **node 20** as this is what also runs in the production environment. If running a higher version and experiencing issues please file a bug report. You can use tools like [nodenv](https://github.com/nodenv/nodenv) diff --git a/scripts/envCheck.js b/scripts/envCheck.js index 77ab533a7..20138a31c 100644 --- a/scripts/envCheck.js +++ b/scripts/envCheck.js @@ -7,8 +7,8 @@ function envCheck() { exec: () => /yarn/.test(process.env.npm_execpath), }, { - message: 'Use Node v18', - exec: () => process.versions.node.split('.')[0] === '18', + message: 'Use Node v20', + exec: () => process.versions.node.split('.')[0] === '20', }, ] diff --git a/yarn.lock b/yarn.lock index 9d03951d8..105960297 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10652,7 +10652,7 @@ __metadata: languageName: node linkType: hard -"@types/node@npm:*, @types/node@npm:18, @types/node@npm:>=12, @types/node@npm:>=12.12.47, @types/node@npm:>=13.7.0, @types/node@npm:^18.11.18": +"@types/node@npm:*, @types/node@npm:>=12, @types/node@npm:>=12.12.47, @types/node@npm:>=13.7.0, @types/node@npm:^18.11.18": version: 18.14.0 resolution: "@types/node@npm:18.14.0" checksum: d83fcf5e4ed544755dd9028f5cbb6b9d46235043159111bb2ad62223729aee581c0144a9f6df8ba73d74011db9ed4ebd7af2fd5e0996714e3beb508a5da8ac5c @@ -10680,6 +10680,13 @@ __metadata: languageName: node linkType: hard +"@types/node@npm:^20.8.0": + version: 20.8.0 + resolution: "@types/node@npm:20.8.0" + checksum: ebad6342d54238a24bf980d7750117a5d67749c9b72cbb7a974a1e932c39034aa3a810d669e007e8a5071782a253aa069a187b614407a382403c9826e837c849 + languageName: node + linkType: hard + "@types/normalize-package-data@npm:^2.4.0": version: 2.4.1 resolution: "@types/normalize-package-data@npm:2.4.1" @@ -19923,7 +19930,7 @@ __metadata: "@types/dateformat": ^3.0.1 "@types/fs-extra": ^9.0.2 "@types/jest": ^29.2.0 - "@types/node": 18 + "@types/node": ^20.8.0 "@types/request": ^2.48.5 "@types/uuid": ^9.0.0 "@types/webpack": ^5.28.0 @@ -27228,7 +27235,7 @@ __metadata: "@types/browser-image-compression": ^1.0.9 "@types/flux-standard-action": 1.1.0 "@types/jest": ^27.4.1 - "@types/node": 18 + "@types/node": ^20.8.0 "@types/pubsub-js": ^1.5.18 "@types/react": 17.0.2 "@types/react-dom": 17.0.2