From 01c5437a27bbae63bf0342eb217784e97647b82f Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Wed, 17 Jan 2018 15:15:38 +0100 Subject: [PATCH] Fix removal of ~length from sets, incorrect single-element tuple syntax The `discard` argument is expected to be a sequence, but the syntax `discard=('elem')` is equivalent to `discard='elem'`. A trailing comma is needed in this case: `discard=('elem',)` so discard is actually a tuple with a single element. --- picard/ui/metadatabox.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/picard/ui/metadatabox.py b/picard/ui/metadatabox.py index ad5763c51..1acce77db 100644 --- a/picard/ui/metadatabox.py +++ b/picard/ui/metadatabox.py @@ -268,7 +268,7 @@ class MetadataBox(QtWidgets.QTableWidget): def contextMenuEvent(self, event): menu = QtWidgets.QMenu(self) if self.objects: - tags = self.selected_tags(discard=('~length')) + tags = self.selected_tags(discard=('~length',)) if len(tags) == 1: selected_tag = tags[0] edit_tag_action = QtWidgets.QAction(_("Edit..."), self.parent) @@ -345,7 +345,7 @@ class MetadataBox(QtWidgets.QTableWidget): EditTagDialog(self.parent, tag).exec_() def edit_selected_tag(self): - tags = self.selected_tags(discard=('~length')) + tags = self.selected_tags(discard=('~length',)) if len(tags) == 1: self.edit_tag(tags[0]) @@ -368,7 +368,7 @@ class MetadataBox(QtWidgets.QTableWidget): self.set_tag_values(tag, [""]) def remove_selected_tags(self): - for tag in self.selected_tags(discard=('~length')): + for tag in self.selected_tags(discard=('~length',)): if self.tag_is_removable(tag): self.remove_tag(tag)