fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-25 10:48:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-321: Support backslash in filenames on non-Windows OS

Browse Source 
With this change backslashes can be used in filenames on systems other than Windows. Only if Windows compatibility is activated backslashes will be replaced as before.
This commit is contained in:
Philipp Wolfer
2019-12-12 17:52:00 +01:00
parent 086da47d72
commit 0855862c8c
6 changed files with 94 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/test_textencoding.py
View File

@@ -2,10 +2,9 @@
from test.picardtestcase import PicardTestCase
from picard import util
from picard.const.sys import IS_WIN
#from picard.util import textencoding
# Set the value to true below to show the coverage of Latin characters
show_latin2ascii_coverage = False
@@ -129,8 +128,12 @@ class PunctuationTest(PicardTestCase):
self.assertEqual(util.textencoding.unicode_simplify_punctuation(ascii_chars), ascii_chars)
def test_pathsave(self):
self.assertEqual(util.textencoding.unicode_simplify_punctuation('\u2215', True), '_')
self.assertEqual(util.textencoding.unicode_simplify_punctuation('/\\\u2215', True), '/\\_')
self.assertEqual(util.textencoding.unicode_simplify_punctuation('\u2215\u2216', True), '__' if IS_WIN else '_\\')
self.assertEqual(util.textencoding.unicode_simplify_punctuation('/\\\u2215\u2216', True), '/\\__' if IS_WIN else '/\\_\\')
def test_pathsave_win_compat(self):
self.assertEqual(util.textencoding.unicode_simplify_punctuation('\u2215\u2216', True, True), '__')
self.assertEqual(util.textencoding.unicode_simplify_punctuation('/\\\u2215\u2216', True, True), '/\\__')
def test_incorrect(self):
pass
@@ -200,7 +203,11 @@ class ReplaceNonAsciiTest(PicardTestCase):
self.assertEqual(util.textencoding.replace_non_ascii(u"１２３"), u"123") # Fullwidth digits
def test_pathsave(self):
self.assertEqual(util.textencoding.replace_non_ascii('\u2044/8½\\', pathsave=True), '_/8 1_2\\')
expected = '__/8 1_2\\' if IS_WIN else '\\_/8 1_2\\'
self.assertEqual(util.textencoding.replace_non_ascii('\u2216\u2044/8½\\', pathsave=True), expected)
def test_win_compat(self):
self.assertEqual(util.textencoding.replace_non_ascii('\u2216\u2044/8½\\', pathsave=True, win_compat=True), '__/8 1_2\\')
def test_incorrect(self):
self.assertNotEqual(util.textencoding.replace_non_ascii(u"Lukáš"), u"Lukáš")