From 39e717c6100bc8b579df9409f958a90e118c425e Mon Sep 17 00:00:00 2001 From: Chad Wilson Date: Sat, 2 Jun 2012 00:43:10 +0800 Subject: [PATCH 1/3] PICARD-33 - Make album drops (right hand pane -> left hand pane drags) also default to unmatched files --- picard/ui/itemviews.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/picard/ui/itemviews.py b/picard/ui/itemviews.py index 45d13d6e9..48866b4d7 100644 --- a/picard/ui/itemviews.py +++ b/picard/ui/itemviews.py @@ -476,6 +476,8 @@ class BaseTreeView(QtGui.QTreeWidget): # application/picard.album-list albums = data.data("application/picard.album-list") if albums: + if target is None: + target = self.tagger.unmatched_files albums = [self.tagger.load_album(id) for id in str(albums).split("\n")] self.drop_albums(albums, target) handled = True From 92f807886632f3d4d56effdcc7f316bfb630ad79 Mon Sep 17 00:00:00 2001 From: Chad Wilson Date: Sat, 2 Jun 2012 00:43:58 +0800 Subject: [PATCH 2/3] Update NEWS --- NEWS.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.txt b/NEWS.txt index 63f7d3b0b..4a5620f1b 100644 --- a/NEWS.txt +++ b/NEWS.txt @@ -14,6 +14,7 @@ Version 1.0 - 2012-06-XX * Lookup in Browser will now not use MBIDs to lookup unmatched files/clusters * Add Date/Country to CD Lookup results dialog (PICARD-198) * Fix/reset album folksonomy tag counts while refreshing releases (PICARD-4) + * Make album drops from right hand pane to left default to "unmatched files" again (PICARD-33) Version 0.16 - 2011-10-23 * Added AcoustID support. From 0ae49d46bbcc1820b93c8f6236835e5b901f066d Mon Sep 17 00:00:00 2001 From: Chad Wilson Date: Sat, 2 Jun 2012 00:48:10 +0800 Subject: [PATCH 3/3] Make it only default to unmatched files only for the FileTreeView (to stop accidental mis-drops when working with albums on right-hand pane) --- picard/ui/itemviews.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/picard/ui/itemviews.py b/picard/ui/itemviews.py index 48866b4d7..cff1f5999 100644 --- a/picard/ui/itemviews.py +++ b/picard/ui/itemviews.py @@ -476,7 +476,7 @@ class BaseTreeView(QtGui.QTreeWidget): # application/picard.album-list albums = data.data("application/picard.album-list") if albums: - if target is None: + if isinstance(self, FileTreeView) and target is None: target = self.tagger.unmatched_files albums = [self.tagger.load_album(id) for id in str(albums).split("\n")] self.drop_albums(albums, target)