From 1e70f73b8e910fb5b06cbabfb079b75d08b4d79b Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Sat, 12 Apr 2014 14:04:53 +0200 Subject: [PATCH] Make strings easier to translate. "%s cover art" (ie. "front cover art") is working in english, but not as well in other languages, especially when type isn't even translated (for now). Replaced with "cover art of type '%s'", which is slightly better when it comes to i18n. --- picard/coverart.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/picard/coverart.py b/picard/coverart.py index fe98936ee..aa2d175e4 100644 --- a/picard/coverart.py +++ b/picard/coverart.py @@ -81,8 +81,9 @@ def _coverart_downloaded(album, metadata, release, try_list, coverinfos, data, h if error: _coverart_http_error(album, http) else: - QObject.tagger.window.set_statusbar_message(N_("%s cover art downloaded for %s from %s"), - coverinfos['type'].title(), album.id, coverinfos['host']) + QObject.tagger.window.set_statusbar_message( + N_("Cover art of type '%s' downloaded for %s from %s"), + coverinfos['type'].title(), album.id, coverinfos['host']) mime = mimetype.get_from_data(data, default="image/jpeg") try: @@ -246,8 +247,9 @@ def _walk_try_list(album, metadata, release, try_list): # We still have some items to try! album._requests += 1 coverinfos = try_list.pop(0) - QObject.tagger.window.set_statusbar_message(N_("Downloading %s cover art for %s from %s ..."), - coverinfos['type'], album.id, coverinfos['host']) + QObject.tagger.window.set_statusbar_message( + N_("Downloading cover art of type '%s' for %s from %s ..."), + coverinfos['type'], album.id, coverinfos['host']) album.tagger.xmlws.download( coverinfos['host'], coverinfos['port'], coverinfos['path'], partial(_coverart_downloaded, album, metadata, release, try_list, coverinfos),