From 29c2f45de1b00b5b81e85b4d6d8b30612aae4b74 Mon Sep 17 00:00:00 2001 From: Antonio Larrosa Date: Wed, 3 Apr 2019 20:04:05 +0200 Subject: [PATCH] Use QDesktopServices to open cover images instead of webbrowser2 QDesktopServices takes care of honoring the user configuration so when opening an image, the user preferred external app is used instead of always using a web browser. Fixes PICARD-1501 --- picard/ui/infodialog.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/picard/ui/infodialog.py b/picard/ui/infodialog.py index b23ff25bc..15e0cf2b1 100644 --- a/picard/ui/infodialog.py +++ b/picard/ui/infodialog.py @@ -38,8 +38,7 @@ from picard.util import ( encode_filename, format_time, htmlescape, - union_sorted_lists, - webbrowser2, + union_sorted_lists ) from picard.ui import PicardDialog @@ -243,7 +242,8 @@ class InfoDialog(PicardDialog): return filename = data.tempfile_filename if filename: - webbrowser2.open("file://" + filename) + url = QtCore.QUrl.fromLocalFile(filename) + QtGui.QDesktopServices.openUrl(url) def format_file_info(file_):