fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-25 10:48:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-2339: Ensure clustering uses most common spelling of the same artist

Browse Source 
This restores previous behavior, where a cluster primary artist is based on the tokenized artist name, but then the most common real spelling is being used.
This commit is contained in:
Philipp Wolfer
2021-11-23 09:48:31 +01:00
parent bb48705357
commit 2aefcd051a
2 changed files with 51 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
test/test_clustering.py
View File

@@ -24,6 +24,7 @@ from test.picardtestcase import PicardTestCase
from picard.cluster import (
Cluster,
FileCluster,
tokenize,
)
from picard.file import File
@@ -120,14 +121,43 @@ class ClusterTest(PicardTestCase):
clusters = list(Cluster.cluster(files))
self.assertEqual(0, len(clusters))
# def test_common_artist_name(self):
# files = [
# self._create_file('cluster 1', 'artist 1'),
# self._create_file('cluster 1', 'artist 2'),
# self._create_file('cluster 1', 'artist2'),
# self._create_file('cluster 1', 'artist 1'),
# self._create_file('cluster 1', 'artist 2'),
# ]
# clusters = list(Cluster.cluster(files))
# self.assertEqual(1, len(clusters))
# self.assertClusterEqual('cluster 1', 'artist 2', files, clusters[0])
def test_common_artist_name(self):
files = [
self._create_file('cluster 1', 'artist 1'),
self._create_file('cluster 1', 'artist 2'),
self._create_file('cluster 1', 'artist2'),
self._create_file('cluster 1', 'artist 1'),
self._create_file('cluster 1', 'artist 2'),
]
clusters = list(Cluster.cluster(files))
self.assertEqual(1, len(clusters))
self.assertClusterEqual('cluster 1', 'artist 2', files, clusters[0])
class FileClusterTest(PicardTestCase):
def test_single(self):
file = File('foo')
fc = FileCluster()
fc.add('album 1', 'artist 1', file)
self.assertEqual('album 1', fc.title)
self.assertEqual('artist 1', fc.artist)
self.assertEqual([file], fc.files)
def test_multi(self):
files = [
File('foo1'),
File('foo2'),
File('foo3'),
File('foo4'),
File('foo5'),
]
fc = FileCluster()
fc.add('album 1', 'artist1', files[0])
fc.add('Album 1', 'artist 2', files[1])
fc.add('album\t1', 'Artist 1', files[2])
fc.add('Album 1', 'Artist 2', files[3])
fc.add('album 2', 'Artist 1', files[4])
self.assertEqual('Album 1', fc.title)
self.assertEqual('Artist 1', fc.artist)
self.assertEqual(files, fc.files)