From 2ee60dadad160ef9aa78202e8616d636a6151a15 Mon Sep 17 00:00:00 2001 From: Sambhav Kothari Date: Mon, 10 Apr 2017 05:15:45 +0530 Subject: [PATCH] PICARD-1058: Fix save file as images There was a str/bytes issue that was causing error on saving CA images as files Fixes: https://tickets.metabrainz.org/browse/PICARD-1058 --- picard/coverart/image.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/picard/coverart/image.py b/picard/coverart/image.py index 261f3fee0..786b1b8eb 100644 --- a/picard/coverart/image.py +++ b/picard/coverart/image.py @@ -289,7 +289,7 @@ class CoverArtImage: filename = self._make_image_filename(filename, dirname, metadata) overwrite = config.setting["save_images_overwrite"] - ext = self.extension + ext = encode_filename(self.extension) image_filename = self._next_filename(filename, counters) while os.path.exists(image_filename + ext) and not overwrite: if not self._is_write_needed(image_filename + ext): @@ -312,7 +312,7 @@ class CoverArtImage: def _next_filename(self, filename, counters): if counters[filename]: - new_filename = "%s (%d)" % (filename, counters[filename]) + new_filename = b"%b (%d)" % (filename, counters[filename]) else: new_filename = filename counters[filename] += 1