From 35f36b177ffec72fa534f71a96ce011dc4cca0dd Mon Sep 17 00:00:00 2001
From: Philipp Wolfer <phil@parolu.io>
Date: Sun, 11 Nov 2018 10:37:12 +0100
Subject: [PATCH] PICARD-1043: Write showmovement only to MP4

Do not write the iTunes specific showmovement tag to formats other than MP4. iTunes does not support this for other formats, and there is no standard way to write this.
---
 picard/formats/apev2.py  | 1 +
 picard/formats/id3.py    | 3 ++-
 picard/formats/vorbis.py | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/picard/formats/apev2.py b/picard/formats/apev2.py
index 073204745..d14841db9 100644
--- a/picard/formats/apev2.py
+++ b/picard/formats/apev2.py
@@ -215,6 +215,7 @@ class APEv2File(File):
             'podcast',
             'podcasturl',
             'show',
+            'showmovement',
             'showsort',
             }
         return bool(name) and name not in unsupported_tags
diff --git a/picard/formats/id3.py b/picard/formats/id3.py
index 884e6ec9d..99b587aca 100644
--- a/picard/formats/id3.py
+++ b/picard/formats/id3.py
@@ -527,7 +527,8 @@ class ID3File(File):
 
     @classmethod
     def supports_tag(cls, name):
-        return ((name and not name.startswith("~"))
+        unsupported_tags = {'showmovement'}
+        return ((name and not name.startswith("~") and name not in unsupported_tags)
                 or name in ("~rating", "~length")
                 or name.startswith("~id3"))
 
diff --git a/picard/formats/vorbis.py b/picard/formats/vorbis.py
index d8922b2a4..cddf01cb0 100644
--- a/picard/formats/vorbis.py
+++ b/picard/formats/vorbis.py
@@ -276,7 +276,8 @@ class VCommentFile(File):
 
     @classmethod
     def supports_tag(cls, name):
-        return bool(name)
+        unsupported_tags = {'showmovement'}
+        return bool(name) and name not in unsupported_tags
 
 
 class FLACFile(VCommentFile):