fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-18 21:53:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-1719: Fix $unset must not mark tags for deletion.

Browse Source 
This regressed in Picard 2.2.0 with commit 503b520 and $unset behaves the same as $delete.
This commit is contained in:
Philipp Wolfer
2020-01-31 17:32:25 +01:00
parent 93b15b8868
commit 3d2a5cf250
4 changed files with 35 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/test_script.py
View File

@@ -69,7 +69,9 @@ class ScriptParserTest(PicardTestCase):
self.assertScriptResultEquals("$right(abcd,x)", "")
def test_cmd_set(self):
self.assertScriptResultEquals("$set(test,aaa)%test%", "aaa")
context = Metadata()
self.assertScriptResultEquals("$set(test,aaa)%test%", "aaa", context)
self.assertEqual(context['test'], 'aaa')
def test_cmd_set_empty(self):
self.assertScriptResultEquals("$set(test,)%test%", "")
@@ -464,6 +466,13 @@ class ScriptParserTest(PicardTestCase):
self.assertNotIn('performer:bar', context)
self.assertNotIn('performer:foo', context)
def test_cmd_unset(self):
context = Metadata()
context['title'] = 'Foo'
self.parser.eval("$unset(title)", context)
self.assertNotIn('title', context)
self.assertNotIn('title', context.deleted_tags)
def test_cmd_delete(self):
context = Metadata()
context['title'] = 'Foo'