From da500c596a6e794ee51703a910ed01073f0f6cc1 Mon Sep 17 00:00:00 2001
From: Bob Swift
Date: Wed, 22 Dec 2021 14:21:01 -0700
Subject: [PATCH 1/3] Add clarification text to scripting options ui
---
picard/ui/ui_options_script.py | 11 ++++++++++-
ui/options_script.ui | 19 ++++++++++++++++++-
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/picard/ui/ui_options_script.py b/picard/ui/ui_options_script.py
index c03ff5066..a8a538b9d 100644
--- a/picard/ui/ui_options_script.py
+++ b/picard/ui/ui_options_script.py
@@ -20,6 +20,14 @@ class Ui_ScriptingOptionsPage(object):
self.enable_tagger_scripts.setObjectName("enable_tagger_scripts")
self.verticalLayout = QtWidgets.QVBoxLayout(self.enable_tagger_scripts)
self.verticalLayout.setObjectName("verticalLayout")
+ self.horizontalLayout_2 = QtWidgets.QHBoxLayout()
+ self.horizontalLayout_2.setContentsMargins(-1, -1, -1, 0)
+ self.horizontalLayout_2.setObjectName("horizontalLayout_2")
+ self.label = QtWidgets.QLabel(self.enable_tagger_scripts)
+ self.label.setWordWrap(True)
+ self.label.setObjectName("label")
+ self.horizontalLayout_2.addWidget(self.label)
+ self.verticalLayout.addLayout(self.horizontalLayout_2)
self.scripting_options_splitter = QtWidgets.QSplitter(self.enable_tagger_scripts)
sizePolicy = QtWidgets.QSizePolicy(QtWidgets.QSizePolicy.Expanding, QtWidgets.QSizePolicy.Expanding)
sizePolicy.setHorizontalStretch(0)
@@ -108,7 +116,8 @@ class Ui_ScriptingOptionsPage(object):
def retranslateUi(self, ScriptingOptionsPage):
_translate = QtCore.QCoreApplication.translate
- self.enable_tagger_scripts.setTitle(_("Tagger Script(s)"))
+ self.enable_tagger_scripts.setTitle(_("Enable Tagger Script(s)"))
+ self.label.setText(_("Checked scripts will be executed automatically, once for each track in the release, when Picard retrieves release information from MusicBrainz.
"))
self.tagger_script.setPlaceholderText(_("Enter your tagger script here."))
self.move_up_button.setToolTip(_("Move script up"))
self.move_down_button.setToolTip(_("Move script down"))
diff --git a/ui/options_script.ui b/ui/options_script.ui
index 7f12aaa4f..6d43ca3ae 100644
--- a/ui/options_script.ui
+++ b/ui/options_script.ui
@@ -29,12 +29,29 @@
-
- Tagger Script(s)
+ Enable Tagger Script(s)
true
+
-
+
+
+ 0
+
+
-
+
+
+ <html><head/><body><p>Checked scripts will be executed automatically, once for each track in the release, when Picard retrieves release information from MusicBrainz.</p></body></html>
+
+
+ true
+
+
+
+
+
-
From 388ce7be0377f13bc02f9f7469c68bfc08a642ce Mon Sep 17 00:00:00 2001
From: Bob Swift
Date: Wed, 22 Dec 2021 14:37:37 -0700
Subject: [PATCH 2/3] Shorten button text to avoid overrunning available button
width
---
picard/ui/ui_options_script.py | 2 +-
ui/options_script.ui | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/picard/ui/ui_options_script.py b/picard/ui/ui_options_script.py
index a8a538b9d..d7f3cf9c5 100644
--- a/picard/ui/ui_options_script.py
+++ b/picard/ui/ui_options_script.py
@@ -127,6 +127,6 @@ class Ui_ScriptingOptionsPage(object):
self.remove_button.setText(_("Remove script"))
self.import_button.setText(_("Import"))
self.export_button.setText(_("Export"))
- self.scripting_documentation_button.setText(_("Scripting Documentation"))
+ self.scripting_documentation_button.setText(_("Documentation"))
from picard.ui.widgets.scriptlistwidget import ScriptListWidget
from picard.ui.widgets.scripttextedit import ScriptTextEdit
diff --git a/ui/options_script.ui b/ui/options_script.ui
index 6d43ca3ae..c68db4494 100644
--- a/ui/options_script.ui
+++ b/ui/options_script.ui
@@ -214,7 +214,7 @@
- Scripting Documentation
+ Documentation
From 9c5ef170c7efd5271186ad45c3c744864563766b Mon Sep 17 00:00:00 2001
From: Bob Swift
Date: Thu, 23 Dec 2021 09:57:45 -0700
Subject: [PATCH 3/3] Slight wording change.
---
picard/ui/ui_options_script.py | 2 +-
ui/options_script.ui | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/picard/ui/ui_options_script.py b/picard/ui/ui_options_script.py
index d7f3cf9c5..e79e1b637 100644
--- a/picard/ui/ui_options_script.py
+++ b/picard/ui/ui_options_script.py
@@ -117,7 +117,7 @@ class Ui_ScriptingOptionsPage(object):
def retranslateUi(self, ScriptingOptionsPage):
_translate = QtCore.QCoreApplication.translate
self.enable_tagger_scripts.setTitle(_("Enable Tagger Script(s)"))
- self.label.setText(_("Checked scripts will be executed automatically, once for each track in the release, when Picard retrieves release information from MusicBrainz.
"))
+ self.label.setText(_("Scripts that have been activated below will be executed automatically for each track of a release loaded from MusicBrainz."))
self.tagger_script.setPlaceholderText(_("Enter your tagger script here."))
self.move_up_button.setToolTip(_("Move script up"))
self.move_down_button.setToolTip(_("Move script down"))
diff --git a/ui/options_script.ui b/ui/options_script.ui
index c68db4494..f092161a1 100644
--- a/ui/options_script.ui
+++ b/ui/options_script.ui
@@ -43,7 +43,7 @@
-
- <html><head/><body><p>Checked scripts will be executed automatically, once for each track in the release, when Picard retrieves release information from MusicBrainz.</p></body></html>
+ Scripts that have been activated below will be executed automatically for each track of a release loaded from MusicBrainz.
true