fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-24 02:09:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify & test MBAPIHelper._collection_request()

Browse Source 
- add batch size as parameter
- use range() step and do not modify passed releases argument
- add test
This commit is contained in:
Laurent Monin
2021-12-27 15:05:28 +01:00
committed by Philipp Wolfer
parent e219435784
commit 6ac0501f55
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/test_api_helpers.py
View File

@@ -179,3 +179,15 @@ class MBAPITest(PicardTestCase):
'</recording-list>'
'</metadata>'
)
def test_collection_request(self):
releases = tuple("r"+str(i) for i in range(13))
generator = self.api._collection_request("test", releases, batchsize=5)
batch = next(generator)
self.assertEqual(batch, ('collection', 'test', 'releases', 'r0;r1;r2;r3;r4'))
batch = next(generator)
self.assertEqual(batch, ('collection', 'test', 'releases', 'r5;r6;r7;r8;r9'))
batch = next(generator)
self.assertEqual(batch, ('collection', 'test', 'releases', 'r10;r11;r12'))
with self.assertRaises(StopIteration):
next(generator)