From 816e942dba7134175dd6f4b2afc2de68a284f8ef Mon Sep 17 00:00:00 2001 From: Rahul Raturi Date: Sun, 17 Jan 2016 16:10:20 +0530 Subject: [PATCH] Improve semantics in commit -> b00152f --- picard/file.py | 2 +- picard/metadata.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/picard/file.py b/picard/file.py index 79a4a1f40..92990c153 100644 --- a/picard/file.py +++ b/picard/file.py @@ -337,7 +337,7 @@ class File(QtCore.QObject, Item): images = [] if config.setting["caa_save_single_front_image"]: images = metadata.get_single_front_image() - if images == []: + if not images: images = metadata.images for image in images: image.save(dirname, metadata, counters) diff --git a/picard/metadata.py b/picard/metadata.py index 5afcb27c7..18464de98 100644 --- a/picard/metadata.py +++ b/picard/metadata.py @@ -60,12 +60,12 @@ class Metadata(dict): # FIXME : rename option at some point # Embed only ONE front image front_image = self.get_single_front_image(images) - if front_image != []: + if front_image: return front_image return images - def get_single_front_image(self, images=[]): - if images == []: + def get_single_front_image(self, images=None): + if not images: images = self.images for img in images: if img.is_front_image():