From 84f4ca3f485edee2cd6b772eee557c162eeea1cb Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Wed, 22 May 2024 22:18:13 +0200 Subject: [PATCH] Move code from _update_imagelist_state() to metadataitem_update_metadata_images() --- picard/item.py | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/picard/item.py b/picard/item.py index d98047b05..16434c82b 100644 --- a/picard/item.py +++ b/picard/item.py @@ -238,10 +238,24 @@ class MetadataItem(Item): return changed - def _update_imagelist_state(self, state): + def metadataitem_update_metadata_images(self): + """Update the metadata images of the current object based on its children. + + Based on the type of the current object, this will update `self.metadata.images` to + represent the metadata images of all children (`Track` or `File` objects). + + This method will iterate over all children and completely rebuild + `self.metadata.images`. Whenever possible the more specific functions + `add_metadata_images` or `remove_metadata_images` should be used. + + Returns: + bool: True, if images where changed, False otherwise + """ from picard.track import Track from picard.util.imagelist import ImageList + state = self._get_imagelist_state() + changed = False for src_obj in state.sources: state.process_images(src_obj, Track) @@ -260,21 +274,6 @@ class MetadataItem(Item): return changed - def metadataitem_update_metadata_images(self): - """Update the metadata images of the current object based on its children. - - Based on the type of the current object, this will update `self.metadata.images` to - represent the metadata images of all children (`Track` or `File` objects). - - This method will iterate over all children and completely rebuild - `self.metadata.images`. Whenever possible the more specific functions - `add_metadata_images` or `remove_metadata_images` should be used. - - Returns: - bool: True, if images where changed, False otherwise - """ - return self._update_imagelist_state(self._get_imagelist_state()) - class FileListItem(MetadataItem):