From 87eaeceafabd8a8675034cd48a9be968d01bb69d Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Sun, 17 Mar 2019 22:39:10 +0100 Subject: [PATCH] Collection: don't be quiet add/remove error Report it on status bar and error log --- picard/collection.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/picard/collection.py b/picard/collection.py index a983a2156..2422e7f01 100644 --- a/picard/collection.py +++ b/picard/collection.py @@ -63,6 +63,7 @@ class Collection(QtCore.QObject): def _finished(self, kind, ids, callback, document, reply, error): self.pending -= ids + statusbar = self.tagger.window.set_statusbar_message if not error: count = len(ids) if kind == self.COLLECTION_ADD: @@ -84,7 +85,13 @@ class Collection(QtCore.QObject): callback() mparms = {'count': count, 'name': self.name} log.debug(debug_msg % mparms) - self.tagger.window.set_statusbar_message(status_msg, mparms, translate=None, echo=None) + statusbar(status_msg, mparms, translate=None, echo=None) + else: + statusbar( + N_("Error while modifying collections: %(error)s"), + {'error': reply.errorString()}, + echo=log.error + ) def load_user_collections(callback=None):