From 8af9db4d94aa2fc7de24d9ecc9beab41b9b50e28 Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Mon, 1 Apr 2024 12:13:11 +0200 Subject: [PATCH] Remove now unused `Version.to_string()` - `v.to_string(short=False)` was replaced by `str(v)` - `v.to_string(short=True)` was replaced by `v.short_str()` --- picard/version.py | 6 ------ test/test_versions.py | 1 - 2 files changed, 7 deletions(-) diff --git a/picard/version.py b/picard/version.py index 081d8851f..babee0ca8 100644 --- a/picard/version.py +++ b/picard/version.py @@ -77,12 +77,6 @@ class Version(namedtuple('VersionBase', 'major minor patch identifier revision') def valid_identifiers(cls): return set(cls._identifiers.keys()) - def to_string(self, short=False): - if short: - return self.short_str() - else: - return str(self) - def short_str(self): if self.identifier in {'alpha', 'beta'}: version = self._replace(identifier=self.identifier[0]) diff --git a/test/test_versions.py b/test/test_versions.py index 0268570ee..c98119c75 100644 --- a/test/test_versions.py +++ b/test/test_versions.py @@ -52,7 +52,6 @@ class VersionsTest(PicardTestCase): ) for v, s in versions: self.assertEqual(str(v), s) - self.assertEqual(v.to_string(), s) self.assertEqual(v, Version.from_string(s)) def test_version_conversion_short(self):