From 8dba1fd7d9e86eff2b187975db83d53125960a65 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Thu, 18 Oct 2018 20:51:14 +0200 Subject: [PATCH] Move can_show_coverart() to Item --- picard/cluster.py | 5 ----- picard/ui/item.py | 5 +++++ picard/ui/mainwindow.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/picard/cluster.py b/picard/cluster.py index fd2752160..2eaa0f285 100644 --- a/picard/cluster.py +++ b/picard/cluster.py @@ -172,11 +172,6 @@ class Cluster(QtCore.QObject, Item): else: return False - @property - def can_show_coverart(self): - """Return if this object supports cover art.""" - return True - def is_album_like(self): return True diff --git a/picard/ui/item.py b/picard/ui/item.py index 203528a6a..9791a9c3c 100644 --- a/picard/ui/item.py +++ b/picard/ui/item.py @@ -47,6 +47,11 @@ class Item(object): def can_view_info(self): return False + @property + def can_show_coverart(self): + """Return if this object supports cover art.""" + return self.can_edit_tags() + def can_browser_lookup(self): return True diff --git a/picard/ui/mainwindow.py b/picard/ui/mainwindow.py index bc57e3585..ba25b990d 100644 --- a/picard/ui/mainwindow.py +++ b/picard/ui/mainwindow.py @@ -1052,7 +1052,7 @@ class MainWindow(QtWidgets.QMainWindow, PreserveGeometry): elif isinstance(obj, Album): metadata = obj.metadata orig_metadata = obj.orig_metadata - elif obj.can_edit_tags(): + elif obj.can_show_coverart: metadata = obj.metadata self.metadata_box.selection_dirty = True