PICARD-2869: Run register_excepthook early

Don't separately catch exceptions around main but rely on the new excepthook.

This prevents the crash dialog to be shown twice for exceptions which
are catched by the exception handler already.

picard/tagger.py

@@ -73,7 +73,6 @@ from picard import (
     PICARD_ORG_NAME,
     acoustid,
     log,
-    register_excepthook,
 )
 from picard.acoustid.manager import AcoustIDManager
 from picard.album import (
@@ -1508,8 +1507,6 @@ If a new instance will not be spawned files/directories will be passed to the ex
 
 
 def main(localedir=None, autoupdate=True):
-    register_excepthook()
-
     # Some libs (ie. Phonon) require those to be set
     QtWidgets.QApplication.setApplicationName(PICARD_APP_NAME)
     QtWidgets.QApplication.setOrganizationName(PICARD_ORG_NAME)

scripts/picard.in

@@ -1,11 +1,7 @@
 #!/usr/bin/env python3
 
-try:
+from picard import register_excepthook
-    from picard.tagger import main
+register_excepthook()
-    main('%(localedir)s', %(autoupdate)s)
+
-except SystemExit:
+from picard.tagger import main
-    raise  # Just continue with a normal application exit
+main('%(localedir)s', %(autoupdate)s)
-except:  # noqa: E722,F722 # pylint: disable=bare-except
-    from picard import crash_handler
-    crash_handler()
-    raise

tagger.py.in

@@ -12,12 +12,8 @@ if getattr(sys, 'frozen', False) and hasattr(sys, '_MEIPASS'):
 else:
     basedir = os.path.dirname(os.path.abspath(__file__))
 
-try:
+from picard import register_excepthook
-    from picard.tagger import main
+register_excepthook()
-    main(os.path.join(basedir, 'locale'), %(autoupdate)s)
+
-except SystemExit:
+from picard.tagger import main
-    raise  # Just continue with a normal application exit
+main(os.path.join(basedir, 'locale'), %(autoupdate)s)
-except:  # noqa: E722,F722 # pylint: disable=bare-except
-    from picard import crash_handler
-    crash_handler()
-    raise