diff --git a/picard/coverart/providers/caa.py b/picard/coverart/providers/caa.py index 929491f2f..c31d6fdaa 100644 --- a/picard/coverart/providers/caa.py +++ b/picard/coverart/providers/caa.py @@ -104,9 +104,6 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): QtWidgets.QDialogButtonBox.RejectRole) self.buttonbox.addButton( StandardButton(StandardButton.HELP), QtWidgets.QDialogButtonBox.HelpRole) - self.buttonbox.accepted.connect(self.accept) - self.buttonbox.rejected.connect(self.reject) - self.buttonbox.helpRequested.connect(self.help) extrabuttons = [ (N_("Chec&k all"), self.checkall), @@ -123,6 +120,7 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): self.buttonbox.accepted.connect(self.accept) self.buttonbox.rejected.connect(self.reject) + self.buttonbox.helpRequested.connect(self.help) def help(self): webbrowser2.goto('doc_cover_art_types') @@ -138,13 +136,8 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): item.setChecked(value) def get_selected_types(self): - types = [] - for item, typ in self._items.items(): - if item.isChecked(): - types.append(typ['name']) - if not types: - return ['front'] - return types + return [typ['name'] for item, typ in self._items.items() if + item.isChecked()] or ['front'] @staticmethod def run(parent=None, types=None): diff --git a/picard/ui/infodialog.py b/picard/ui/infodialog.py index 439a78379..4c13e4ac5 100644 --- a/picard/ui/infodialog.py +++ b/picard/ui/infodialog.py @@ -30,6 +30,7 @@ from picard.util import (format_time, encode_filename, union_sorted_lists, htmlescape) from picard.ui import PicardDialog from picard.ui.ui_infodialog import Ui_InfoDialog +from picard.ui.util import StandardButton class ArtworkCoverWidget(QtWidgets.QWidget): @@ -113,8 +114,9 @@ class InfoDialog(PicardDialog): self.existing_images = [] self.display_existing_artwork = False self.ui.setupUi(self) + self.ui.buttonBox.addButton( + StandardButton(StandardButton.CLOSE), QtWidgets.QDialogButtonBox.AcceptRole) self.ui.buttonBox.accepted.connect(self.accept) - self.ui.buttonBox.rejected.connect(self.reject) # Add the ArtworkTable to the ui self.ui.artwork_table = ArtworkTable(self.display_existing_artwork) @@ -258,7 +260,7 @@ def format_file_info(file_): else: ch = string_(ch) info.append((_('Channels:'), ch)) - return '
'.join(map(lambda i: '%s
%s' % + return '
'.join(map(lambda i: '%s %s' % (htmlescape(i[0]), htmlescape(i[1])), info)) diff --git a/picard/ui/ui_infodialog.py b/picard/ui/ui_infodialog.py index 5740794ff..1ed1edf0a 100644 --- a/picard/ui/ui_infodialog.py +++ b/picard/ui/ui_infodialog.py @@ -22,7 +22,7 @@ class Ui_InfoDialog(object): self.info_scroll.setObjectName("info_scroll") self.scrollAreaWidgetContents = QtWidgets.QWidget() self.scrollAreaWidgetContents.setEnabled(True) - self.scrollAreaWidgetContents.setGeometry(QtCore.QRect(0, 0, 493, 334)) + self.scrollAreaWidgetContents.setGeometry(QtCore.QRect(0, 0, 493, 358)) self.scrollAreaWidgetContents.setObjectName("scrollAreaWidgetContents") self.verticalLayoutLabel = QtWidgets.QVBoxLayout(self.scrollAreaWidgetContents) self.verticalLayoutLabel.setContentsMargins(0, 0, 0, 0) @@ -44,7 +44,7 @@ class Ui_InfoDialog(object): self.tabWidget.addTab(self.artwork_tab, "") self.verticalLayout.addWidget(self.tabWidget) self.buttonBox = QtWidgets.QDialogButtonBox(InfoDialog) - self.buttonBox.setStandardButtons(QtWidgets.QDialogButtonBox.Cancel|QtWidgets.QDialogButtonBox.Ok) + self.buttonBox.setStandardButtons(QtWidgets.QDialogButtonBox.NoButton) self.buttonBox.setObjectName("buttonBox") self.verticalLayout.addWidget(self.buttonBox) diff --git a/picard/ui/util.py b/picard/ui/util.py index cc2db640a..201bcbf2c 100644 --- a/picard/ui/util.py +++ b/picard/ui/util.py @@ -28,11 +28,13 @@ class StandardButton(QtWidgets.QPushButton): OK = 0 CANCEL = 1 HELP = 2 + CLOSE = 4 __types = { OK: (N_('&Ok'), 'SP_DialogOkButton'), CANCEL: (N_('&Cancel'), 'SP_DialogCancelButton'), HELP: (N_('&Help'), 'SP_DialogHelpButton'), + CLOSE: (N_('Clos&e'), 'SP_DialogCloseButton'), } def __init__(self, btntype): diff --git a/ui/infodialog.ui b/ui/infodialog.ui index f02c47d42..792bf615e 100644 --- a/ui/infodialog.ui +++ b/ui/infodialog.ui @@ -35,7 +35,7 @@ 0 0 493 - 334 + 358 @@ -65,15 +65,14 @@ A&rtwork - - + - QDialogButtonBox::Cancel|QDialogButtonBox::Ok + QDialogButtonBox::NoButton