From 9c709c7ee461e1a3dc85fa8d2df6817a55dd57f9 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Wed, 29 May 2019 12:29:40 +0200 Subject: [PATCH] PICARD-1516: Fix loading / saving MP4 without tags --- picard/formats/mp4.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/picard/formats/mp4.py b/picard/formats/mp4.py index 46d421d17..b73008ec4 100644 --- a/picard/formats/mp4.py +++ b/picard/formats/mp4.py @@ -130,10 +130,7 @@ class MP4File(File): def _load(self, filename): log.debug("Loading file %r", filename) file = MP4(encode_filename(filename)) - tags = file.tags - if tags is None: - file.add_tags() - + tags = file.tags or {} metadata = Metadata() for name, values in tags.items(): if name in self.__text_tags: @@ -182,9 +179,9 @@ class MP4File(File): def _save(self, filename, metadata): log.debug("Saving file %r", filename) file = MP4(encode_filename(self.filename)) - tags = file.tags - if tags is None: + if file.tags is None: file.add_tags() + tags = file.tags if config.setting["clear_existing_tags"]: tags.clear()