From 9d2dd7cf3514dd60371ff19df667b730aa6ab3da Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Thu, 5 Nov 2020 08:31:03 +0100 Subject: [PATCH] PICARD-2007: Disable fingerprinting for MIDI files Audio fingerprinting can by design not work on MIDI files --- picard/formats/midi.py | 3 +++ picard/tagger.py | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/picard/formats/midi.py b/picard/formats/midi.py index bf5689dc7..13512dd98 100644 --- a/picard/formats/midi.py +++ b/picard/formats/midi.py @@ -54,3 +54,6 @@ class MIDIFile(File): @classmethod def supports_tag(cls, name): return False + + def can_analyze(self): + return False diff --git a/picard/tagger.py b/picard/tagger.py index 23352986f..a16753b22 100644 --- a/picard/tagger.py +++ b/picard/tagger.py @@ -798,9 +798,9 @@ class Tagger(QtWidgets.QApplication): return files = self.get_files_from_objects(objs) for file in files: - file.set_pending() - self._acoustid.analyze(file, partial(file._lookup_finished, - File.LOOKUP_ACOUSTID)) + if file.can_analyze(): + file.set_pending() + self._acoustid.analyze(file, partial(file._lookup_finished, File.LOOKUP_ACOUSTID)) def generate_fingerprints(self, objs): """Generate the fingerprints without matching the files."""