From 9dbbc428523693b4fde2945377a320830ee261bf Mon Sep 17 00:00:00 2001 From: Michael Wiencek Date: Tue, 13 Nov 2012 23:30:42 -0600 Subject: [PATCH] 'add new tag' writes to different field than specified (PICARD-348) --- picard/ui/edittagdialog.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/picard/ui/edittagdialog.py b/picard/ui/edittagdialog.py index 9b5048379..7c5847552 100644 --- a/picard/ui/edittagdialog.py +++ b/picard/ui/edittagdialog.py @@ -96,12 +96,12 @@ class EditTagDialog(QtGui.QDialog): new_tags = self.metadata_box.tag_diff.new display_value, different = new_tags.display_value(self.tag) if different: + values = [display_value] self.different = True - self._add_value_items([display_value], italic=True) self.ui.add_value.setEnabled(False) - return - values = new_tags[self.tag] - self._add_value_items(values) + else: + values = new_tags[self.tag] + self._add_value_items(values, italic=self.different) self.value_list.setCurrentItem(self.value_list.item(0), QtGui.QItemSelectionModel.SelectCurrent) tag_names.editTextChanged.connect(self.tag_changed)