From a56fcfe49c077fb15bc7353aacbe444a413d3dcd Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Thu, 13 Aug 2020 09:27:57 +0200 Subject: [PATCH] PICARD-1909: Ensure main window gets updated on metadata changes --- picard/ui/mainwindow.py | 4 ++-- picard/ui/metadatabox.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/picard/ui/mainwindow.py b/picard/ui/mainwindow.py index e1a9dda8e..71d678d6c 100644 --- a/picard/ui/mainwindow.py +++ b/picard/ui/mainwindow.py @@ -1112,7 +1112,7 @@ class MainWindow(QtWidgets.QMainWindow, PreserveGeometry): self.tags_from_filenames_action.setEnabled(bool(files)) self.track_search_action.setEnabled(have_objects) - def update_selection(self, objects=None, new_selection=True): + def update_selection(self, objects=None, new_selection=True, drop_album_caches=False): if self.ignore_selection_changes: return @@ -1178,7 +1178,7 @@ class MainWindow(QtWidgets.QMainWindow, PreserveGeometry): if new_selection: self.metadata_box.selection_dirty = True - self.metadata_box.update() + self.metadata_box.update(drop_album_caches=drop_album_caches) self.cover_art_box.set_metadata(metadata, orig_metadata, obj) self.selection_updated.emit(objects) diff --git a/picard/ui/metadatabox.py b/picard/ui/metadatabox.py index 959ef6f76..a4552fe77 100644 --- a/picard/ui/metadatabox.py +++ b/picard/ui/metadatabox.py @@ -395,7 +395,7 @@ class MetadataBox(QtWidgets.QTableWidget): def _apply_update_funcs(self, funcs): for f in funcs: f() - self.update(drop_album_caches=True) + self.parent.update_selection(new_selection=False, drop_album_caches=True) def edit_tag(self, tag): EditTagDialog(self.parent, tag).exec_() @@ -432,7 +432,7 @@ class MetadataBox(QtWidgets.QTableWidget): for tag in self.selected_tags(discard=('~length',)): if self.tag_is_removable(tag): self.remove_tag(tag) - self.update(drop_album_caches=True) + self.parent.update_selection(new_selection=False, drop_album_caches=True) def tag_is_removable(self, tag): return self.tag_diff.status[tag] & TagStatus.NOTREMOVABLE == 0