From a662a67334ce6d2cf7f3078110f3bbdc9f481f45 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Mon, 21 Sep 2020 21:22:34 +0200 Subject: [PATCH] Copy track orig_metadata after plugins have been run This makes the behavior consistent with the album and avoids that we need to rerun the plugins on file matches. --- picard/album.py | 2 +- picard/track.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/picard/album.py b/picard/album.py index 7860c87ba..21a8bb85e 100644 --- a/picard/album.py +++ b/picard/album.py @@ -422,7 +422,6 @@ class Album(DataObject, Item): tm.copy(metadata) track_to_metadata(track_node, track) tm["~absolutetracknumber"] = absolutetracknumber - track.orig_metadata.copy(tm) track._customize_metadata() self._new_metadata.length += tm.length @@ -440,6 +439,7 @@ class Album(DataObject, Item): except BaseException: self.error_append(traceback.format_exc()) + track.orig_metadata.copy(tm) return track def load(self, priority=False, refresh=False): diff --git a/picard/track.py b/picard/track.py index 9730881e0..3603db4db 100644 --- a/picard/track.py +++ b/picard/track.py @@ -415,9 +415,9 @@ class NonAlbumTrack(Track): def _parse_recording(self, recording): m = self.metadata recording_to_metadata(recording, m, self) - self.orig_metadata.copy(m) self._customize_metadata() run_track_metadata_processors(self.album, m, recording) + self.orig_metadata.copy(m) self.run_scripts(m) self.loaded = True self.status = None