From baba955cf0c9c59655a62c2a204f2fc26d0609b3 Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Tue, 9 Nov 2021 17:25:20 +0100 Subject: [PATCH] Since the pattern matching is case-insensitive, lowercase pattern string - it helps to remove duplicates (like cover.jpg cover.JPG) - fix test accordingly --- picard/file.py | 2 +- test/test_file.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/picard/file.py b/picard/file.py index 06fa73390..d0f281e03 100644 --- a/picard/file.py +++ b/picard/file.py @@ -561,7 +561,7 @@ class File(QtCore.QObject, Item): self._apply_additional_files_moves(moves) def _compile_move_additional_files_pattern(self, config): - patterns = config.setting["move_additional_files_pattern"] + patterns = config.setting["move_additional_files_pattern"].lower() pattern_regexes = set() for pattern in patterns.split(): pattern = pattern.strip() diff --git a/test/test_file.py b/test/test_file.py index 05fdaa41b..e3cfb32e4 100644 --- a/test/test_file.py +++ b/test/test_file.py @@ -408,6 +408,5 @@ class FileAdditionalFilesPatternsTest(PicardTestCase): (re.compile('(?s:c.ver\\.jpg)\\Z', re.IGNORECASE), False), (re.compile('(?s:\\.h.dden.*)\\Z', re.IGNORECASE), True), (re.compile('(?s:.*\\.jpg)\\Z', re.IGNORECASE), False), - (re.compile('(?s:.*\\.JPG)\\Z', re.IGNORECASE), False) } self.assertEqual(f._compile_move_additional_files_pattern(config), expected)