fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-26 11:18:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-1715: Allow changing file extension in renaming script

Browse Source
This commit is contained in:
Philipp Wolfer
2020-01-28 13:30:36 +01:00
parent ab5aa68b4f
commit bcc81d86eb
4 changed files with 34 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/test_scripttofilename.py
View File

@@ -32,39 +32,48 @@ class ScriptToFilenameTest(PicardTestCase):
def test_plain_filename(self):
metadata = Metadata()
filename = script_to_filename('AlbumArt', metadata)
(filename, new_metadata) = script_to_filename('AlbumArt', metadata)
self.assertEqual('AlbumArt', filename)
def test_simple_script(self):
metadata = Metadata()
metadata['artist'] = 'AC/DC'
metadata['album'] = 'The Album'
filename = script_to_filename('%album%', metadata)
(filename, new_metadata) = script_to_filename('%album%', metadata)
self.assertEqual('The Album', filename)
filename = script_to_filename('%artist%/%album%', metadata)
(filename, new_metadata) = script_to_filename('%artist%/%album%', metadata)
self.assertEqual('AC_DC/The Album', filename)
def test_preserve_backslash(self):
metadata = Metadata()
metadata['artist'] = 'AC\\/DC'
filename = script_to_filename('%artist%', metadata)
(filename, new_metadata) = script_to_filename('%artist%', metadata)
self.assertEqual('AC__DC' if IS_WIN else 'AC\\_DC', filename)
def test_file_metadata(self):
metadata = Metadata()
file = File('somepath/somefile.mp3')
self.assertEqual('', script_to_filename('$has_file()', metadata))
self.assertEqual('1', script_to_filename('$has_file()', metadata, file=file))
self.assertEqual('', script_to_filename('$has_file()', metadata)[0])
self.assertEqual('1', script_to_filename('$has_file()', metadata, file=file)[0])
def test_update_metadata(self):
metadata = Metadata()
metadata['artist'] = 'Foo'
metadata['~extension'] = 'foo'
(filename, new_metadata) = script_to_filename('$set(_extension,bar)\n%artist%', metadata)
self.assertEqual('Foo', filename)
self.assertEqual('foo', metadata['~extension'])
self.assertEqual('bar', new_metadata['~extension'])
def test_ascii_filenames(self):
metadata = Metadata()
metadata['artist'] = 'Die Ärzte'
settings = config.setting.copy()
settings['ascii_filenames'] = False
filename = script_to_filename('%artist% éöü½', metadata, settings=settings)
(filename, new_metadata) = script_to_filename('%artist% éöü½', metadata, settings=settings)
self.assertEqual('Die Ärzte éöü½', filename)
settings['ascii_filenames'] = True
filename = script_to_filename('%artist% éöü½', metadata, settings=settings)
(filename, new_metadata) = script_to_filename('%artist% éöü½', metadata, settings=settings)
self.assertEqual('Die Arzte eou 1_2', filename)
def test_windows_compatibility(self):
@@ -74,10 +83,10 @@ class ScriptToFilenameTest(PicardTestCase):
settings['windows_compatibility'] = False
expect_orig = '\\*:?'
expect_compat = '____'
filename = script_to_filename('%artist%?', metadata, settings=settings)
(filename, new_metadata) = script_to_filename('%artist%?', metadata, settings=settings)
self.assertEqual(expect_compat if IS_WIN else expect_orig, filename)
settings['windows_compatibility'] = True
filename = script_to_filename('%artist%?', metadata, settings=settings)
(filename, new_metadata) = script_to_filename('%artist%?', metadata, settings=settings)
self.assertEqual(expect_compat, filename)
@unittest.skipUnless(IS_WIN, "windows test")
@@ -93,21 +102,21 @@ class ScriptToFilenameTest(PicardTestCase):
metadata['artist'] = '\u2216/\\\u2215'
settings = config.setting.copy()
settings['ascii_filenames'] = True
filename = script_to_filename('%artist%/\u2216\\\\\u2215', metadata, settings=settings)
(filename, new_metadata) = script_to_filename('%artist%/\u2216\\\\\u2215', metadata, settings=settings)
self.assertEqual('____/_\\_', filename)
def test_remove_null_chars(self):
metadata = Metadata()
filename = script_to_filename('a\x00b\x00', metadata)
(filename, new_metadata) = script_to_filename('a\x00b\x00', metadata)
self.assertEqual('ab', filename)
def test_remove_tabs_and_linebreaks_chars(self):
metadata = Metadata()
filename = script_to_filename('a\tb\nc', metadata)
(filename, new_metadata) = script_to_filename('a\tb\nc', metadata)
self.assertEqual('abc', filename)
def test_preserve_leading_and_trailing_whitespace(self):
metadata = Metadata()
metadata['artist'] = 'The Artist'
filename = script_to_filename(' %artist% ', metadata)
(filename, new_metadata) = script_to_filename(' %artist% ', metadata)
self.assertEqual(' The Artist ', filename)