From 9f7ae34bf40d6b422c42b07d17bb517e589c5f9d Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Fri, 8 Sep 2023 15:35:24 +0200 Subject: [PATCH] Fixed regresson in script editor Revert use of qlistwidget_items for getting the script list, as this is a QComboBox and not QListWidget. --- picard/ui/scripteditor.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/picard/ui/scripteditor.py b/picard/ui/scripteditor.py index c66dc5154..ed6331892 100644 --- a/picard/ui/scripteditor.py +++ b/picard/ui/scripteditor.py @@ -81,7 +81,6 @@ from picard.ui.options.scripting import ( ) from picard.ui.ui_scripteditor import Ui_ScriptEditor from picard.ui.ui_scripteditor_details import Ui_ScriptDetails -from picard.ui.util import qlistwidget_items from picard.ui.widgets.scriptdocumentation import ScriptingDocumentationWidget @@ -972,10 +971,11 @@ class ScriptEditorDialog(PicardDialog, SingletonDialog): Returns: dict: Dictionary of scripts """ - return { - item['id']: item - for item in qlistwidget_items(self.ui.preset_naming_scripts) - } + naming_scripts = {} + for idx in range(self.ui.preset_naming_scripts.count()): + script_item = self.ui.preset_naming_scripts.itemData(idx) + naming_scripts[script_item["id"]] = script_item + return naming_scripts def get_selected_item(self, idx=None): """Get the specified item from the script selection combo box.