From 5e766dbd115e151aae9a32712952d6e07cc2b903 Mon Sep 17 00:00:00 2001 From: Sambhav Kothari Date: Sat, 13 May 2017 16:51:24 +0530 Subject: [PATCH] Remove unused imports --- picard/__init__.py | 1 - picard/config_upgrade.py | 1 - picard/coverart/providers/amazon.py | 1 - picard/coverart/providers/caa.py | 2 -- picard/coverart/providers/caa_release_group.py | 2 -- picard/coverart/providers/local.py | 1 - picard/coverart/providers/whitelist.py | 1 - picard/formats/wav.py | 1 - picard/ui/infodialog.py | 1 - picard/ui/itemviews.py | 1 - picard/ui/ui_infodialog.py | 2 -- 11 files changed, 14 deletions(-) diff --git a/picard/__init__.py b/picard/__init__.py index 8c2b6d805..947f80526 100644 --- a/picard/__init__.py +++ b/picard/__init__.py @@ -45,7 +45,6 @@ def version_to_string(version, short=False): n = int(p) except ValueError: n = p - pass _version.append(n) version = tuple(_version) if short and version[3] == 'final': diff --git a/picard/config_upgrade.py b/picard/config_upgrade.py index 8bdffe167..31cc16b13 100644 --- a/picard/config_upgrade.py +++ b/picard/config_upgrade.py @@ -191,7 +191,6 @@ def upgrade_to_v1_4_0_dev_4(): def upgrade_to_v1_4_0_dev_5(): """Using Picard.ini configuration file on all platforms""" # this is done in Config.__init__() - pass def upgrade_to_v1_4_0_dev_6(): diff --git a/picard/coverart/providers/amazon.py b/picard/coverart/providers/amazon.py index e8f54c8d9..147b0cacc 100644 --- a/picard/coverart/providers/amazon.py +++ b/picard/coverart/providers/amazon.py @@ -22,7 +22,6 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -import traceback from picard import log from picard.util import parse_amazon_url diff --git a/picard/coverart/providers/caa.py b/picard/coverart/providers/caa.py index 764388266..19972ab49 100644 --- a/picard/coverart/providers/caa.py +++ b/picard/coverart/providers/caa.py @@ -22,7 +22,6 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -import traceback from PyQt5 import QtCore, QtWidgets from PyQt5.QtNetwork import QNetworkReply from picard import config, log @@ -33,7 +32,6 @@ from picard.coverart.utils import CAA_TYPES, translate_caa_type from picard.ui.ui_provider_options_caa import Ui_CaaOptions from picard.ui.util import StandardButton from picard.util import webbrowser2, load_json -from picard.ui.options import OptionsPage, OptionsCheckError, register_options_page _CAA_THUMBNAIL_SIZE_MAP = { diff --git a/picard/coverart/providers/caa_release_group.py b/picard/coverart/providers/caa_release_group.py index 90dc28675..e2a8ceb48 100644 --- a/picard/coverart/providers/caa_release_group.py +++ b/picard/coverart/providers/caa_release_group.py @@ -17,9 +17,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -import traceback -from picard.coverart.providers import CoverArtProvider from picard.coverart.providers.caa import CoverArtProviderCaa from picard.coverart.image import CaaCoverArtImage, CaaThumbnailCoverArtImage diff --git a/picard/coverart/providers/local.py b/picard/coverart/providers/local.py index 73e1defaf..0ca1ce743 100644 --- a/picard/coverart/providers/local.py +++ b/picard/coverart/providers/local.py @@ -19,7 +19,6 @@ import os import re -import traceback from picard import config from picard.coverart.providers import CoverArtProvider, ProviderOptions from picard.coverart.image import CoverArtImageFromFile diff --git a/picard/coverart/providers/whitelist.py b/picard/coverart/providers/whitelist.py index 8c384f192..cfcf66722 100644 --- a/picard/coverart/providers/whitelist.py +++ b/picard/coverart/providers/whitelist.py @@ -22,7 +22,6 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -import traceback from picard import log from picard.coverart.providers import CoverArtProvider diff --git a/picard/formats/wav.py b/picard/formats/wav.py index 46e9294a5..87420f318 100644 --- a/picard/formats/wav.py +++ b/picard/formats/wav.py @@ -43,4 +43,3 @@ class WAVFile(File): def _save(self, filename, metadata): log.debug("Saving file %r", filename) - pass diff --git a/picard/ui/infodialog.py b/picard/ui/infodialog.py index 72f8cb74a..64f2f6afa 100644 --- a/picard/ui/infodialog.py +++ b/picard/ui/infodialog.py @@ -168,7 +168,6 @@ class InfoDialog(PicardDialog): data = image.thumbnail.data except CoverArtImageIOError as e: log.warning(e) - pass else: data = image.data except CoverArtImageIOError: diff --git a/picard/ui/itemviews.py b/picard/ui/itemviews.py index 647921fdb..6ee893c90 100644 --- a/picard/ui/itemviews.py +++ b/picard/ui/itemviews.py @@ -19,7 +19,6 @@ import os import re -import sys from functools import partial from PyQt5 import QtCore, QtGui, QtWidgets from picard import config, log diff --git a/picard/ui/ui_infodialog.py b/picard/ui/ui_infodialog.py index 99fabe2d7..5740794ff 100644 --- a/picard/ui/ui_infodialog.py +++ b/picard/ui/ui_infodialog.py @@ -16,7 +16,6 @@ class Ui_InfoDialog(object): self.info_tab = QtWidgets.QWidget() self.info_tab.setObjectName("info_tab") self.vboxlayout = QtWidgets.QVBoxLayout(self.info_tab) - self.vboxlayout.setContentsMargins(0, 0, 0, 0) self.vboxlayout.setObjectName("vboxlayout") self.info_scroll = QtWidgets.QScrollArea(self.info_tab) self.info_scroll.setWidgetResizable(True) @@ -41,7 +40,6 @@ class Ui_InfoDialog(object): self.artwork_tab = QtWidgets.QWidget() self.artwork_tab.setObjectName("artwork_tab") self.vboxlayout1 = QtWidgets.QVBoxLayout(self.artwork_tab) - self.vboxlayout1.setContentsMargins(0, 0, 0, 0) self.vboxlayout1.setObjectName("vboxlayout1") self.tabWidget.addTab(self.artwork_tab, "") self.verticalLayout.addWidget(self.tabWidget)