From cd188dcebffe9050de1fb90bfdac5516b68290c0 Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Tue, 9 Nov 2021 17:45:26 +0100 Subject: [PATCH] Rewrite to use a set comprehension - using strip() isn't needed as split(sep=None) will take care of multiple whitespaces - from 10 lines to 4, and likely a tad faster --- picard/file.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/picard/file.py b/picard/file.py index d0f281e03..a7d7c4c82 100644 --- a/picard/file.py +++ b/picard/file.py @@ -561,16 +561,10 @@ class File(QtCore.QObject, Item): self._apply_additional_files_moves(moves) def _compile_move_additional_files_pattern(self, config): - patterns = config.setting["move_additional_files_pattern"].lower() - pattern_regexes = set() - for pattern in patterns.split(): - pattern = pattern.strip() - if not pattern: - continue - pattern_regex = re.compile(fnmatch.translate(pattern), re.IGNORECASE) - match_hidden = pattern.startswith('.') - pattern_regexes.add((pattern_regex, match_hidden)) - return pattern_regexes + return { + (re.compile(fnmatch.translate(pattern), re.IGNORECASE), pattern.startswith('.')) + for pattern in set(config.setting["move_additional_files_pattern"].lower().split()) + } def _get_additional_files_moves(self, old_path, new_path, patterns): moves = set()