fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-25 10:48:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

PICARD-2361: Fix clustering using removed files

Browse Source
This commit is contained in:
Philipp Wolfer
2021-12-14 08:08:08 +01:00
parent 2b5e8010f1
commit d1a7063c56
3 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/test_clustering.py
View File

@@ -73,8 +73,7 @@ class ClusterTest(PicardTestCase):
self._create_file('album foo', 'artist foo'),
]
clusters = list(Cluster.cluster(files))
# No cluster is being created for single files
self.assertEqual(0, len(clusters))
self.assertEqual(1, len(clusters))
def test_cluster_single_cluster(self):
files = [
@@ -92,12 +91,13 @@ class ClusterTest(PicardTestCase):
self._create_file('album cluster2', 'artist foo'),
self._create_file('album cluster1', 'artist foo'),
self._create_file('albumcluster2', 'artist bar'),
self._create_file('album nocluster', 'artist bar'),
self._create_file('album single', 'artist bar'),
]
clusters = list(Cluster.cluster(files))
self.assertEqual(2, len(clusters))
self.assertEqual(3, len(clusters))
self.assertClusterEqual('album cluster1', 'artist bar', {files[0], files[2]}, clusters[0])
self.assertClusterEqual('album cluster2', 'artist foo', {files[1], files[3]}, clusters[1])
self.assertClusterEqual('album single', 'artist bar', {files[4]}, clusters[2])
def test_cluster_by_path(self):
files = [
@@ -105,13 +105,14 @@ class ClusterTest(PicardTestCase):
self._create_file(None, None, 'album2/foo1.ogg'),
self._create_file(None, None, 'artist1/album1/foo2.ogg'),
self._create_file(None, None, 'album2/foo2.ogg'),
self._create_file(None, None, 'nocluster/foo.ogg'),
self._create_file(None, None, 'single/foo.ogg'),
self._create_file(None, None, 'album1/foo3.ogg'),
]
clusters = list(Cluster.cluster(files))
self.assertEqual(2, len(clusters))
self.assertEqual(3, len(clusters))
self.assertClusterEqual('album1', 'artist1', {files[0], files[2], files[5]}, clusters[0])
self.assertClusterEqual('album2', 'Diverse Interpreten', {files[1], files[3]}, clusters[1])
self.assertClusterEqual('single', 'Diverse Interpreten', {files[4]}, clusters[2])
def test_cluster_no_metadata(self):
files = [
@@ -143,7 +144,7 @@ class FileClusterTest(PicardTestCase):
fc.add('album 1', 'artist 1', file)
self.assertEqual('album 1', fc.title)
self.assertEqual('artist 1', fc.artist)
self.assertEqual([file], fc.files)
self.assertEqual([file], list(fc.files))
def test_multi(self):
files = [
@@ -161,4 +162,4 @@ class FileClusterTest(PicardTestCase):
fc.add('album 2', 'Artist 1', files[4])
self.assertEqual('Album 1', fc.title)
self.assertEqual('Artist 1', fc.artist)
self.assertEqual(files, fc.files)
self.assertEqual(files, list(fc.files))