From 568906fcb77f4e5db082fb97880220e6f5226fe7 Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Tue, 6 Mar 2018 11:57:34 +0100 Subject: [PATCH 1/2] Drop redundant connect() calls --- picard/coverart/providers/caa.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/picard/coverart/providers/caa.py b/picard/coverart/providers/caa.py index 929491f2f..3ea932da2 100644 --- a/picard/coverart/providers/caa.py +++ b/picard/coverart/providers/caa.py @@ -104,9 +104,6 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): QtWidgets.QDialogButtonBox.RejectRole) self.buttonbox.addButton( StandardButton(StandardButton.HELP), QtWidgets.QDialogButtonBox.HelpRole) - self.buttonbox.accepted.connect(self.accept) - self.buttonbox.rejected.connect(self.reject) - self.buttonbox.helpRequested.connect(self.help) extrabuttons = [ (N_("Chec&k all"), self.checkall), @@ -123,6 +120,7 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): self.buttonbox.accepted.connect(self.accept) self.buttonbox.rejected.connect(self.reject) + self.buttonbox.helpRequested.connect(self.help) def help(self): webbrowser2.goto('doc_cover_art_types') From c38cf101c07d335f6dd434a3128b4e998bad78ce Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Tue, 6 Mar 2018 12:01:40 +0100 Subject: [PATCH 2/2] CAATypesSelectorDialog.get_selected_types(): use list comprehension and simplify --- picard/coverart/providers/caa.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/picard/coverart/providers/caa.py b/picard/coverart/providers/caa.py index 3ea932da2..c31d6fdaa 100644 --- a/picard/coverart/providers/caa.py +++ b/picard/coverart/providers/caa.py @@ -136,13 +136,8 @@ class CAATypesSelectorDialog(QtWidgets.QDialog): item.setChecked(value) def get_selected_types(self): - types = [] - for item, typ in self._items.items(): - if item.isChecked(): - types.append(typ['name']) - if not types: - return ['front'] - return types + return [typ['name'] for item, typ in self._items.items() if + item.isChecked()] or ['front'] @staticmethod def run(parent=None, types=None):