From d92d2ea903b511b0167b983b72c040ddbcd484fe Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Wed, 11 Dec 2019 18:47:55 +0100 Subject: [PATCH] PICARD-1692: Use ClickableSlider for all sliders in the UI This better reflects user expectation and slider behavior in other applications across all platforms. --- picard/ui/options/releases.py | 3 ++- picard/ui/widgets/__init__.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/picard/ui/options/releases.py b/picard/ui/options/releases.py index 857b78508..1432b8987 100644 --- a/picard/ui/options/releases.py +++ b/picard/ui/options/releases.py @@ -40,13 +40,14 @@ from picard.ui.options import ( register_options_page, ) from picard.ui.ui_options_releases import Ui_ReleasesOptionsPage +from picard.ui.widgets import ClickableSlider _DEFAULT_SCORE = 0.5 _release_type_scores = [(g, _DEFAULT_SCORE) for g in list(RELEASE_PRIMARY_GROUPS.keys()) + list(RELEASE_SECONDARY_GROUPS.keys())] -class TipSlider(QtWidgets.QSlider): +class TipSlider(ClickableSlider): _offset = QtCore.QPoint(0, -30) _step = 5 diff --git a/picard/ui/widgets/__init__.py b/picard/ui/widgets/__init__.py index 82ececa19..1d6ee383e 100644 --- a/picard/ui/widgets/__init__.py +++ b/picard/ui/widgets/__init__.py @@ -118,7 +118,7 @@ class SliderPopover(Popover): self.label.setAlignment(QtCore.Qt.AlignCenter) vbox.addWidget(self.label) - self.slider = QtWidgets.QSlider(self) + self.slider = ClickableSlider(self) self.slider.setOrientation(QtCore.Qt.Horizontal) self.slider.setValue(value) self.slider.valueChanged.connect(self.value_changed)