From ea701ecd4b7f17aafa9ef8d520a69a5f56d09e22 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Wed, 21 Aug 2019 11:45:58 +0200 Subject: [PATCH] PICARD-1580: Fixed crash when closing options window If the options window gets closed via window controls regsitered signals are already disconnected before the hideEvent gets called. --- picard/ui/options/releases.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/picard/ui/options/releases.py b/picard/ui/options/releases.py index 941ef9f67..857b78508 100644 --- a/picard/ui/options/releases.py +++ b/picard/ui/options/releases.py @@ -74,7 +74,10 @@ class TipSlider(QtWidgets.QSlider): def hideEvent(self, event): super().hideEvent(event) if not IS_WIN: - self.valueChanged.disconnect(self.show_tip) + try: + self.valueChanged.disconnect(self.show_tip) + except TypeError: + pass def show_tip(self, value): self.round_value(value)