From eefe7e35f39b02fb9ad8a04bf0845c0bc6c994b3 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Thu, 6 Jul 2023 15:18:22 +0200 Subject: [PATCH] Revert "PICARD-2609: Run metadata comparison on file.update in a thread" This reverts commit 8a3a3424b913635bd36302a8b67d9901c3fc040e. --- picard/file.py | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/picard/file.py b/picard/file.py index 96648670e..003c3a6f6 100644 --- a/picard/file.py +++ b/picard/file.py @@ -697,13 +697,6 @@ class File(QtCore.QObject, Item): yield name def update(self, signal=True): - thread.run_task( - self._compare_metadata, - partial(self._compare_metadata_finished, signal), - thread_pool=self.tagger.priority_thread_pool - ) - - def _compare_metadata(self): if not (self.state == File.ERROR and self.errors): config = get_config() clear_existing_tags = config.setting["clear_existing_tags"] @@ -731,10 +724,6 @@ class File(QtCore.QObject, Item): self.state = File.CHANGED else: self.state = File.NORMAL - - def _compare_metadata_finished(self, signal, result=None, error=None): - if error: - log.error("Comparing file metadata for %r failed: %s", self, error) if signal: log.debug("Updating file %r", self) self.update_item()