From fac0ed5155235e77d02519ab233dc688d682d94d Mon Sep 17 00:00:00 2001 From: Laurent Monin Date: Sat, 13 Apr 2024 18:20:36 +0200 Subject: [PATCH] Add support for title to Option.add_if_missing() --- picard/config.py | 4 ++-- test/test_config.py | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/picard/config.py b/picard/config.py index 39e3d10ea..1ca4b813d 100644 --- a/picard/config.py +++ b/picard/config.py @@ -401,9 +401,9 @@ class Option(QtCore.QObject): return opt.title @classmethod - def add_if_missing(cls, section, name, default): + def add_if_missing(cls, section, name, default, *args, **kwargs): if not cls.exists(section, name): - cls(section, name, default) + cls(section, name, default, *args, **kwargs) @classmethod def exists(cls, section, name): diff --git a/test/test_config.py b/test/test_config.py index c70b43f17..48f9b9a32 100644 --- a/test/test_config.py +++ b/test/test_config.py @@ -110,8 +110,9 @@ class TestPicardConfigOption(TestPicardConfigCommon): Option.add_if_missing("setting", "option", "def") self.assertEqual(self.config.setting["option"], "abc") - Option.add_if_missing("setting", "missing_option", "def") + Option.add_if_missing("setting", "missing_option", "def", title="TITLE") self.assertEqual(self.config.setting["missing_option"], "def") + self.assertEqual(Option.get_title('setting', 'missing_option'), 'TITLE') def test_double_declaration(self): Option("setting", "option", "abc")