Commit Graph

639 Commits

Author SHA1 Message Date
Philipp Wolfer
ac91895629 PICARD-1803: Fixed decamelcasing relationship attributes
EWI must not become E W I
2020-04-17 22:02:10 +02:00
Undearius
df85263762 PICARD-1800: Simplify Unicode 'Bullet' to ASCII 'Hyphen-minus' 2020-03-29 12:45:15 +02:00
Philipp Wolfer
f812681092 PICARD-1795: Allow deleting iTunNORM and iTunPGAP tags from ID3 2020-03-28 20:01:58 +00:00
Ray
afcab0f779 Parse additional fields from the AcoustId response 2020-03-18 08:41:04 +00:00
Laurent Monin
04a98581a3 Merge pull request #1514 from rdswift/fix_function_location_info_and_add_to_runtimeerror_tests
Fix function line, column in ScriptRuntimeError.  Add tests.
2020-03-07 01:19:16 +01:00
Bob Swift
2b07885c69 Add missing formatting code. Update test for missing code. 2020-03-06 14:18:57 -07:00
Bob Swift
46937bab8b Combine StackItem classes into one. Standardize exception prefix text. 2020-03-06 10:18:07 -07:00
Philipp Wolfer
b2a850c007 PICARD-1788: Fix case-insensitive saving of ID3 TXXX frames 2020-03-06 17:05:04 +01:00
Philipp Wolfer
96e429f83a PICARD-1787: ID3 fix deleting case-insensitive TXXX frames 2020-03-06 17:00:53 +01:00
Philipp Wolfer
880a3c3443 Added ID3 tests for deleting tags in __rename_freetext 2020-03-06 16:45:32 +01:00
Philipp Wolfer
bb4c417d04 PICARD-1786: Fix ID3 deleting multiple TIPL items with same role
Added tests for deleting TIPL entries from ID3, fixed issue of multiple people with same role not getting removed.
2020-03-06 16:45:25 +01:00
Philipp Wolfer
80b1b9ea93 PICARD-1785: Fix deleting ID3 tags with explicit ~id3: syntax 2020-03-06 16:41:26 +01:00
Philipp Wolfer
062e75afb8 Test saving license to ID3 2020-03-06 13:47:38 +01:00
Philipp Wolfer
6e8f4ed5d2 Improve format test coverage 2020-03-06 13:47:38 +01:00
Philipp Wolfer
83be0ae5a3 Added tests for loading unsupported images from tags 2020-03-06 12:46:30 +00:00
Bob Swift
d5de2dc159 Use StackItem and FunctionStackItem with script exception calls 2020-03-05 15:35:16 -07:00
Laurent Monin
053f57666a _CAA_THUMBNAIL_SIZE_MAP: use '500' instead of historical 'large' for thumbnail URLs 2020-03-05 15:49:20 +01:00
Laurent Monin
9c261325fe _CAA_THUMBNAIL_SIZE_MAP: use '250' instead of historical 'small' for thumbnail URLs 2020-03-05 15:46:56 +01:00
Laurent Monin
2529d98151 caa_url_fallback_list(): add support for size aliases
It makes it more future-proof, and we'll let us use 500 and 250 instead of historical large and small
Add/modify related tests
2020-03-05 15:43:12 +01:00
Laurent Monin
4892309e95 test_caa_url_fallback_list(): add few explanations 2020-03-05 15:32:54 +01:00
Laurent Monin
ac84aba3a2 test_caa_url_fallback_list(): Improve assertion error message 2020-03-05 15:31:22 +01:00
Laurent Monin
1ee61dd4a7 caa_url_fallback_list() test: assert TypeError exceptions in case of bad args 2020-03-05 15:07:20 +01:00
Laurent Monin
2507644eca Test picard.coverart.providers.caa.caa_url_fallback_list() 2020-03-05 14:59:15 +01:00
Bob Swift
61d9196b92 Fix function line, column in ScriptRuntimeError. Add tests. 2020-03-04 16:14:45 -07:00
Laurent Monin
38a05d6eaa Merge pull request #1508 from rdswift/PICARD-1776
PICARD-1776: Trap ValueError exception in $datetime function
2020-03-04 23:19:45 +01:00
Philipp Wolfer
7f6db1bde6 PCIARD-1783: Fixed regex escaping for tag descriptions in Vorbis and APEv2 2020-03-04 07:02:06 +00:00
Philipp Wolfer
57c8fe209a PICARD-1783: Fix deletion of comment, performer and lyrics tags
This adds tests for deleting comment, performer and lyrics tags and fixes various issues with this in ID3, MP4, Vorbis and APEv2.
2020-03-04 07:02:06 +00:00
Bob Swift
462ba2d74b Remove unnecessary "except..." code. 2020-03-03 15:17:14 -07:00
Bob Swift
1ccaebb28f Fix line, position order and add line number to test. 2020-03-03 15:07:33 -07:00
Bob Swift
64a379aeb2 Use thread-safe function stack. Add platform-specific tests. 2020-03-03 15:07:32 -07:00
Bob Swift
030fd17251 Add function_stack to parser. Revise ScriptRuntimeError args. 2020-03-03 15:06:07 -07:00
Bob Swift
5a8df90074 Added ScriptRuntimeError. Remove unnecessary non-Win tests. 2020-03-03 15:05:42 -07:00
Bob Swift
1c1f2998f4 Trap ValueError exception in $datetime function and add tests 2020-03-03 15:04:19 -07:00
Bob Swift
60d9827fa6 PICARD-1781: Have $find return '' rather than '-1' on not found 2020-03-03 17:19:02 +00:00
Bob Swift
becd3e0d7a Add IndexError check to $firstwords function 2020-02-28 07:47:38 +00:00
Philipp Wolfer
c1c9cf6bf6 PICARD-1774: Fix MultiValue returning [] on empty value
This also fixes issues with some functions:
- $lenmulti with empty value must return 0
- $foreach and $map must loop zero times on empty value
2020-02-27 08:25:01 +00:00
Bob Swift
05ea186c29 Fix negative length handling in $num 2020-02-26 22:25:44 +00:00
Bob Swift
1bd45a0c59 Add ZeroDivisionError handling in $mod function 2020-02-26 22:22:47 +00:00
Laurent Monin
6b5e852a60 Run fix-header on *.py 2020-02-24 10:25:09 +01:00
Philipp Wolfer
7e937e851a PICARD-1765: Adding / removing preserved tags must normalize the tags 2020-02-24 08:49:22 +00:00
Laurent Monin
b5a97c9926 Merge pull request #1493 from zas/cov_cleanup
Coverage & cleanup
2020-02-24 00:34:49 +01:00
Laurent Monin
3585d40b0b PICARD-1762: fix broken PDF identification
In identify(), comparaison was done against `str` instead of `bytecode`, due to the lack of `b` prefix

ImageInfoTest: add missing test PDF file identification
2020-02-23 13:07:30 +00:00
Laurent Monin
ed351fbbd6 ImageInfoTest: remove useless ending comma 2020-02-22 21:04:32 +01:00
Laurent Monin
77a9d0110a AlbumArtistFromPathTest: add a bunch of missing tests 2020-02-22 21:04:32 +01:00
Laurent Monin
27f04356d5 TranslateArtistTest: ensure name is returned in latin-only case
The previous test wasn't that good as a reversed sortname could actually assert true
2020-02-22 21:04:32 +01:00
Laurent Monin
af5e9d647e TranslateArtistTest: improve coverage
Cases with non-latin and 3 or 4 chunks were missing
2020-02-22 21:04:32 +01:00
Laurent Monin
bd95736da4 TranslateArtistTest: u"" -> "" (Python3) 2020-02-22 21:04:32 +01:00
Laurent Monin
64bfb17733 TranslateArtistTest: remove useless assertNotEqual()
Since we assert a equals b, no need to assert a not equal c when b & c are different
Coverage is unchanged.
2020-02-22 21:04:32 +01:00
Laurent Monin
42d0a72b74 Improve coverage of union_sorted_lists() tests 2020-02-22 21:04:32 +01:00
Bob Swift
170b8e0aa7 Add $sortmulti, $reversemulti and associated tests 2020-02-22 19:24:13 +00:00