Commit Graph

244 Commits

Author SHA1 Message Date
Laurent Monin
e905a5f716 Merge pull request #709 from Sophist-UK/PICARD-1075_Add-unit-tests-for-Metadata-object-variables
PICARD-1075: Add unit tests for Metadata object variables
2017-05-11 11:07:06 +02:00
Sophist
c067bd5e26 Merge branch 'master' into PICARD-922_improve-inmulti-as-per-1.4.1 2017-05-11 08:26:15 +01:00
samj1912
094eff232c Merge branch 'master' into fix-mutable 2017-05-10 19:08:50 +05:30
samj1912
11ac00d153 Merge branch 'master' into ibmi 2017-05-10 18:01:02 +05:30
Sambhav Kothari
d03c66033e Avoid mutable default arguments 2017-05-10 17:23:02 +05:30
Sambhav Kothari
93c46dbce8 Update version_to_string to follow PEP440 2017-05-09 14:53:30 +05:30
Shen-Ta Hsieh
d0d9711a37 Update test/data/mb.png size for test_png
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2017-05-05 17:54:13 +08:00
Shen-Ta Hsieh
a3f74679e1 Recompress all png files
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2017-05-05 16:57:30 +08:00
Sophist
303cf79390 Use assertScriptResultEquals...
... instead of assertEqual(self.parser.eval
2017-05-03 09:09:27 +01:00
Wieland Hoffmann
05b343a232 Reject functions with required keyword-only arguments
Python 3 / PEP3102 introduced keyword-only arguments, like in

  def foo(a, *, b):
    pass

where `b` can't be set as a positional argument. This can't be expressed in
tagger script, so reject calls to register such functions.

This also gets rid of a DeprecationWarning for inspect.getargspec.

Signed-off-by: Wieland Hoffmann <themineo@gmail.com>
2017-05-01 18:27:07 +02:00
Sophist
9bb4802144 Add explanatory comments 2017-05-01 13:50:35 +01:00
Sophist
f4ce8e2ca6 Add tests for override with standard sep 2017-05-01 13:44:33 +01:00
Sophist
fca5061a11 Add seperator override tests for $lenmulti 2017-05-01 13:36:29 +01:00
Sophist
64e3c89180 Fix bug with default separator overridden. 2017-05-01 13:28:56 +01:00
Sophist
602dfbb36e Add $lenmulti function 2017-04-29 14:01:50 +01:00
Sophist
60983a2a22 Fix copymerge
1. Newsvals deduped
2. Oldvals in original sequence
2017-04-29 14:01:50 +01:00
Sophist
0b4b14ce9c Fix $inmulti as per #623 2017-04-29 14:01:22 +01:00
Sophist
6474915c00 Remove unneeded imports, refactor code. 2017-04-27 12:26:08 +01:00
Sophist
1112ea432c Add unit testsfor Metadata object variables 2017-04-26 22:53:57 +01:00
Wieland Hoffmann
a749e996e7 Remove unused imports 2017-04-17 18:14:46 +02:00
Wieland Hoffmann
06dd81b78e Move the self.assertEqual(self.parser.eval(...), ...) pattern to a function 2017-04-17 18:14:20 +02:00
Wieland Hoffmann
896b62a3b5 test_astrcmp: Rephrase the skip message to not refer to a not existing file 2017-04-11 19:03:34 +02:00
Wieland Hoffmann
fb89d5e93c Remove unused imports 2017-04-11 19:00:32 +02:00
Sophist
ef67ba9b88 Address review comments
Thanks to @mineo for his help.
2017-04-10 18:19:07 +01:00
Sophist
9c9335439e Fix astrcmp tests if not compiled 2017-04-10 16:18:01 +01:00
Lukáš Lalinský
bf7934d848 Add astrcmp tests 2017-04-08 15:29:12 +02:00
Sambhav Kothari
9992ade39d Fix py3 compatibility
sip.setapi is no longer needed with PyQt5 and py3.
Thus it was removed.
2017-04-07 16:45:35 +05:30
Sambhav Kothari
51041be6a3 Fix test bytes error 2017-04-07 16:06:15 +05:30
Sambhav Kothari
69251f2907 Fix decode error 2017-04-07 16:06:15 +05:30
Sambhav Kothari
8a6285e7dc Fix cover art test bytes issue 2017-04-07 16:06:15 +05:30
Sambhav Kothari
b0fcc9eedf Fix test_script 2017-04-07 16:06:15 +05:30
Sambhav Kothari
4be5ce8f5e Replace deprecated file method and rename formats.open to formats.open_ 2017-04-07 13:17:37 +05:30
Sambhav Kothari
236b1d155d Fix dictionary behaviour for py3 2017-04-07 13:17:37 +05:30
Sambhav Kothari
428e168b87 Port Picard to Qt5 2017-04-03 16:45:42 +05:30
Ville Skyttä
2070d9f008 Python 3.6 invalid escape sequence deprecation fixes
https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior
2017-02-28 15:29:23 +02:00
Laurent Monin
1013cd5ed7 Revert "PICARD-922: Fix inmulti behaviour with multi-values" 2017-02-15 11:38:35 +01:00
Antonio Larrosa
b7c324b4de Fix PEP8 issues (mostly lines too large)
Add a few empty lines and wrap some lines so they're not so large
2017-02-13 15:41:20 +01:00
Antonio Larrosa
85282935f6 Add test for the inmulti function
Add a test to check that the inmulti function works as expected.
2017-02-12 20:47:15 +01:00
Sambhav Kothari
2ed4fbe8d4 Add tests for startswith and endswith functions 2017-01-19 02:18:09 +05:30
Sambhav Kothari
427c98c862 Add tests for _fixed_splitext 2017-01-16 02:32:13 +05:30
Laurent Monin
6cc8ebce72 Merge pull request #549 from samj1912/picard384
PICARD-384: Allow wildcards for unsetting certain tags
2017-01-14 15:44:36 +01:00
Sambhav Kothari
69c4abe2b5 Add tests for arbitrary number of arguments 2017-01-13 22:06:59 +01:00
Sambhav Kothari
d028418d2e Add more tests for unset script function 2017-01-13 03:24:06 +05:30
Sambhav Kothari
fe65394c88 Add tests for unset script function 2017-01-13 03:06:55 +05:30
Laurent Monin
9c033389e6 Merge pull request #528 from samj1912/picard868
PICARD-868,307: Fix TMOO,TSST frame not being saved
2017-01-10 21:51:33 +01:00
Sambhav Kothari
4dd5a66a94 Update tests to remove unsupported AIFF tags 2017-01-09 00:28:02 +05:30
Sambhav Kothari
e005d541fe Minor changes to function names 2017-01-07 03:23:14 +05:30
Sambhav Kothari
1b35b91f8c Add tests to check id3v23 compatibility 2017-01-07 02:24:18 +05:30
Sambhav Kothari
2b36896e5d Add tests to check for performer duplication 2017-01-06 22:51:08 +05:30
Laurent Monin
639a6ed531 Merge pull request #523 from samj1912/delmp3
PICARD-867: Improve id3 tag deletion
2017-01-05 18:39:04 +01:00