Commit Graph

89 Commits

Author SHA1 Message Date
Philipp Wolfer
892693be67 PICARD-2775: Mitigate libwebp vulnerability (CVE-2023-4863)
A libwebp vulnerarbility allows arbitrary code execution when loading
a manipulated image. Disable the Qt webp imageformat plugin for binary
builds for macOS and Windows for now. WebP images still can be loaded
and saved, but they will not be displayed.
2023-10-10 16:18:35 +02:00
Philipp Wolfer
118f5f7b66 Build macOS and Windows packages with libdiscid 0.6.4 2023-09-22 14:49:21 +02:00
Philipp Wolfer
d47cec4877 Double quote shell variables to prevent globbing and word splitting 2023-09-22 07:12:30 +02:00
Philipp Wolfer
2a3ad2a3f5 Fail packaging on Windows code signing errors 2023-09-21 11:08:02 +02:00
Philipp Wolfer
05d605d1d5 PICARD-2760: Use SignTool for all Windows code signing
This tool is more flexible then the than the Powershell commandlet and
unifies code signing between .exe and .appx packages.
2023-09-21 10:56:12 +02:00
Philipp Wolfer
0e1993c111 PICARD-2760: Timestamp the Windows binaries when codesigning
This ensures the final binaries are still accepted by the OS even after
the certificates have expired.
2023-09-21 10:56:12 +02:00
Philipp Wolfer
2a89c2edf2 Use named parameters in powershell script 2023-09-08 09:49:53 +02:00
Philipp Wolfer
7c7de584a6 PICARD-2724: Move all Qt5 DLLs into main directory on Windows
Avoids import errors if a system wide, incompatible Qt5 installation
is present on the system.
2023-09-08 09:49:53 +02:00
Philipp Wolfer
203524c238 PICARD-2736: Fix Windows system wide libssl conflicting with bundled libssl
Removed an old workaround that no longer applies for current PyQt5
and/or PyInstaller. The OpenSSL DLLs should be kept in the main install
folder in order to be prioritized over system libs.
2023-08-31 09:28:44 +02:00
Philipp Wolfer
7ee078852a Use notarytool for macOS notarization
Notarization with the altool has been deprecated, see
https://developer.apple.com/documentation/technotes/tn3147-migrating-to-the-latest-notarization-tool
2023-06-14 23:33:15 +02:00
Philipp Wolfer
db3ff8969a Use binary builds of libdiscid for macOS 2023-02-28 22:05:10 +01:00
Philipp Wolfer
c4c66df644 Package libdiscid 0.6.3 for Windows and macOS builds 2023-02-28 22:05:10 +01:00
Philipp Wolfer
bb1014bc19 Use different Python versions for different macOS builds 2022-12-21 10:20:54 +01:00
Philipp Wolfer
0a9b259e43 Build macOS packages with latest Python 3.11 2022-12-20 21:49:21 +01:00
Philipp Wolfer
1233d45336 PICARD-2192: Build macOS packages with fpcalc universal
Allows native ARM support for fpcalc. Partially addresses PICARD-2192
2022-12-16 18:31:14 +01:00
Philipp Wolfer
05ec3d5f5f Make setting the publisher based on certificate subject part of APPX build script 2022-10-31 16:28:24 +01:00
Philipp Wolfer
45f1e1a21d Use environment variable PICARD_BUILD_PORTABLE to trigger portable build
Fixes latest pyinstaller no longer accepting the --onefile parameter if called with a spec.
2022-07-22 10:19:28 +02:00
Philipp Wolfer
5e3fa405af PICARD-2422: Removed packaging of AB streaming extractor 2022-02-16 11:46:21 +01:00
Philipp Wolfer
29ed9d79d2 PICARD-2395: Fixed building for macOS 2022-01-12 08:54:21 +01:00
Philipp Wolfer
c511137ef6 Revert "Removed Qt translations workaround no longer needed with current PyInstaller"
This reverts commit 5f0e598385.
2022-01-12 08:54:21 +01:00
Philipp Wolfer
197efffec1 packaging: Verify SHA256 hashes of downloaded Windows dependencies 2021-12-25 17:37:54 +01:00
Philipp Wolfer
42508ec5d3 Enclose command parameters in quotation marks 2021-12-24 14:15:17 +01:00
Philipp Wolfer
471065964c packaging: verify checksums for macOS downloaded dependencies 2021-12-24 12:30:06 +01:00
Laurent Monin
368221b840 Workaround hdiutil: create failed - Resource busy with a loop/delay 2021-12-03 12:54:52 +01:00
Philipp Wolfer
2f34f3cd2e Fixed appx signing 2021-11-10 15:05:56 +01:00
Philipp Wolfer
f22c3ea965 Use SecureString in Windows Powershell packaging script 2021-11-10 14:59:42 +01:00
Philipp Wolfer
52e64f16c0 macOS: Build with newer essentia extractor binary
Use the for now unofficial builds from https://github.com/phw/essentia-extractor-builds/releases/tag/v2.1_beta2_1 which are compiled with newer SDK. The official binaries cannot be used because they cannot be notarized.
2021-10-06 08:24:48 +02:00
Philipp Wolfer
2422d74cb3 macOS: Handle different command line syntax for xpath on Big Sur 2021-09-25 14:52:37 +02:00
Philipp Wolfer
5f0e598385 Removed Qt translations workaround no longer needed with current PyInstaller 2021-09-25 14:50:11 +02:00
a1346054
990bec0460 Fix whitespace 2021-08-29 15:02:06 +02:00
a1346054
f086f61575 Fix shellcheck warnings 2021-08-29 15:02:06 +02:00
Philipp Wolfer
d9d748e423 Skip bundling essentia-extractor in macOS builds for now
Workaround to fix macOS notarization until we get an essentia extractor build with macOS SDK 10.9 or later
2021-08-23 17:25:01 +02:00
Gabriel Ferreira
f42f78b0de AcousticBrainz feature extraction and submission support
Co-authored-by: Laurent Monin <github@norz.org>
Co-authored-by: Philipp Wolfer <ph.wolfer@gmail.com>
2021-08-22 12:46:57 +02:00
Philipp Wolfer
bba20a28ab Allow disabling graphical crash handler with --no-crash-dialog
This is mainly for running Picard in CI environments and debugging
2021-05-17 17:54:21 +02:00
Philipp Wolfer
6ac80aaf82 Double quote parameters in shell scripts 2021-04-06 17:58:19 +02:00
Philipp Wolfer
be7b578c75 PICARD-1943: Fix macOS app signature breaking on macOS 10.12/10.13
Avoid signature being written to extended file system attributes by moving resource files to Contents/Resources.
2020-12-31 20:15:54 +01:00
Philipp Wolfer
19bafa2999 macOS: Only test package after build if it was codesigned
Without code signing this will likely fail due to signature errors
2020-12-26 16:53:41 +01:00
Philipp Wolfer
3c50b3ea4e More verbose output in macOS build script 2020-12-26 16:41:54 +01:00
Philipp Wolfer
293c2c730f macos: build with Python 3.9.1 2020-12-26 15:30:13 +01:00
Philipp Wolfer
09aa1b7467 macos: verify notarization and code signature 2020-12-26 15:30:12 +01:00
Philipp Wolfer
8d8e8c186c Create separate builds for macOS 10.12+ and 10.14+ 2020-12-26 15:30:12 +01:00
Philipp Wolfer
1814a02313 Update macOS distribution certificate
Update the mechanism to work exactly as we do it for the Windows code signing.
2020-10-28 14:23:45 +01:00
Philipp Wolfer
0a5aba7c8f PICARD-1958: Add a symlink to /Applications to macOS DMG 2020-10-02 20:06:32 +02:00
Philipp Wolfer
d7b1dae98b macOS: Handle OS version 11.0 in package script (#1646) 2020-10-02 20:03:07 +02:00
Philipp Wolfer
a52f97b133 PICARD-1935: Include tests in sdist
Verify in CI the sdist package is complete and passes tests.
2020-09-04 13:38:27 +02:00
Philipp Wolfer
069428c8fc win_setup: Log versions of downloaded libdiscid / fpcalc 2020-06-18 10:19:13 +02:00
Philipp Wolfer
b50b14a093 Upgrade to fpcalc 1.5.0 for Windows and macOS builds 2020-04-17 22:00:29 +02:00
Philipp Wolfer
84e6322bc3 CI: Split building Windows packages into separate jobs
Upload separate artifacts and build in parallel.
2020-01-29 08:31:26 +01:00
Philipp Wolfer
d552063fdf Use updated builds of fpcalc for windows
For consistency with macOS version. Using updated builds with latest FFmpeg
2020-01-21 18:40:17 +01:00
Philipp Wolfer
e82767e0d8 PICARD-1707: Download updated macOS fpcalc build
Using a macOS fpcalc build from custom repository until an official new version build with newer macOS SDK is available.
2020-01-21 14:08:53 +01:00