Commit Graph

668 Commits

Author SHA1 Message Date
Philipp Wolfer
a2207df8ba PICARD-1853: Fix crash in natsort on superscript numeric chars 2020-06-25 18:18:12 +02:00
Philipp Wolfer
b0a01a99ac PICARD-1853: Fix natsort crashing on strings with '\0' 2020-06-23 20:18:05 +02:00
Philipp Wolfer
cbe88786a6 PICARD-1846: Do not raise KeyError in Metadata.unset 2020-06-19 14:47:03 +02:00
Philipp Wolfer
ddd9c9d4d9 Merge pull request #1555 from Gabrielcarvfer/Performance
PICARD-1844: Further improve loading and clustering performance
2020-06-19 08:37:57 +02:00
Gabriel Ferreira
e843b4f3ed Update statusbar with clustering progress 2020-06-18 14:33:57 -03:00
Philipp Wolfer
149e02c914 PICARD-1840: For instrumental recordings unset lyricist
Also set language to zxx ("No lyrics"), fixes PICARD-1117
2020-06-17 21:34:02 +02:00
Philipp Wolfer
8cea3807c0 PICARD-1820: Allow single digit versions like "2" to be parsed
A version 2 is equivalent to 2.0 or 2.0.0.
2020-06-08 18:22:32 +02:00
Philipp Wolfer
df8010cf02 PICARD-1826: Consider .ogg files as generic Ogg container files
Fixes e.g. loading Ogg Opus files with .ogg extension, instead of assuming .ogg is always Ogg Vorbis.
2020-05-24 16:34:38 +02:00
Philipp Wolfer
419ff87fea PICARD-1807: Fix error handling when using python-libdiscid
discid.disc.DiscError only exists in python-discid, not in the compat version of python-libdiscid. The proper way in both libraries is to access discid.DiscError.
2020-05-13 19:12:16 +02:00
Philipp Wolfer
651bbad60d Merge pull request #1534 from phw/PICARD-1812-riff-info
PICARD-1812: Save RIFF INFO tags for WAVE
2020-05-13 19:11:08 +02:00
Philipp Wolfer
d79d142a04 Refactor picard.formats and picard.coverart.providers to avoid circular dependencies 2020-05-13 17:04:11 +02:00
Philipp Wolfer
bb7c45ddf8 PICARD-1812: Tests for loading / saving RIFF INFO tags 2020-05-13 13:50:05 +02:00
Philipp Wolfer
1542d4d7c0 PICARD-1812: Option to remove RIFF INFO from WAVE files 2020-05-13 11:08:07 +02:00
Philipp Wolfer
b8644aad3d PICARD-1812: Options for saving RIFF INFO to WAVE 2020-05-13 11:08:07 +02:00
Philipp Wolfer
0996495cee PICARD-1128: Allow tagging WAVE files with ID3
Requires support in mutagen
2020-05-13 11:06:37 +02:00
Laurent Monin
a308c39343 preprocessor -> postprocessor
Suggested by @phw
2020-05-13 11:05:11 +02:00
Laurent Monin
7ec406f8bd Display module for script functions registered outside picard 2020-05-13 11:05:10 +02:00
Laurent Monin
06c2618232 Improve script function documentation formatting, using dl/dt/dd html tags
Make color of the first line configurable (demo mode)
2020-05-13 11:05:10 +02:00
Laurent Monin
66632e9761 Sort script functions documentation 2020-05-13 11:05:10 +02:00
Laurent Monin
d52bfd83b1 Make markdown module optional, fix tests accordingly 2020-05-13 11:05:09 +02:00
Laurent Monin
b284c841c4 Also test FunctionRegistryItem() 2020-05-13 11:05:09 +02:00
Laurent Monin
7d0e185a85 Fix up script function documentation tests
- ensure registry is empty
- use actual html code as returned by markdown
- split code among different test methods
2020-05-13 11:05:09 +02:00
Laurent Monin
7508cbf743 Reduce code redundancy, add helpers assertStartswith() and assertEndswith() 2020-05-13 11:05:09 +02:00
Laurent Monin
310bed488a Add script_function_documentation_all() to dump all script functions documentation 2020-05-13 11:05:09 +02:00
Laurent Monin
a7680bf75e script_function_documentation(): returns function doc in wanted format, add tests 2020-05-13 11:05:09 +02:00
Philipp Wolfer
fb83a8e76b Enable flake8 E265: Block comment should start with '# '
Most changes involve replacing non-breaking space with a simple space after the #.
2020-05-13 11:03:13 +02:00
Philipp Wolfer
909ea667b8 Check code style of tests with flake8 2020-05-13 11:03:13 +02:00
Philipp Wolfer
ee8b88cf2a Avoid using ambiguous variable name "l"
Fixes the issue E741 reported by flake8 >= 3.8.
https://www.flake8rules.com/rules/E741.html
2020-05-12 19:33:13 +02:00
Philipp Wolfer
a3bb51993f PICARD-1813: Fixed calling $title with empty value 2020-05-09 10:46:57 +02:00
Philipp Wolfer
ac91895629 PICARD-1803: Fixed decamelcasing relationship attributes
EWI must not become E W I
2020-04-17 22:02:10 +02:00
Undearius
df85263762 PICARD-1800: Simplify Unicode 'Bullet' to ASCII 'Hyphen-minus' 2020-03-29 12:45:15 +02:00
Philipp Wolfer
f812681092 PICARD-1795: Allow deleting iTunNORM and iTunPGAP tags from ID3 2020-03-28 20:01:58 +00:00
Ray
afcab0f779 Parse additional fields from the AcoustId response 2020-03-18 08:41:04 +00:00
Laurent Monin
04a98581a3 Merge pull request #1514 from rdswift/fix_function_location_info_and_add_to_runtimeerror_tests
Fix function line, column in ScriptRuntimeError.  Add tests.
2020-03-07 01:19:16 +01:00
Bob Swift
2b07885c69 Add missing formatting code. Update test for missing code. 2020-03-06 14:18:57 -07:00
Bob Swift
46937bab8b Combine StackItem classes into one. Standardize exception prefix text. 2020-03-06 10:18:07 -07:00
Philipp Wolfer
b2a850c007 PICARD-1788: Fix case-insensitive saving of ID3 TXXX frames 2020-03-06 17:05:04 +01:00
Philipp Wolfer
96e429f83a PICARD-1787: ID3 fix deleting case-insensitive TXXX frames 2020-03-06 17:00:53 +01:00
Philipp Wolfer
880a3c3443 Added ID3 tests for deleting tags in __rename_freetext 2020-03-06 16:45:32 +01:00
Philipp Wolfer
bb4c417d04 PICARD-1786: Fix ID3 deleting multiple TIPL items with same role
Added tests for deleting TIPL entries from ID3, fixed issue of multiple people with same role not getting removed.
2020-03-06 16:45:25 +01:00
Philipp Wolfer
80b1b9ea93 PICARD-1785: Fix deleting ID3 tags with explicit ~id3: syntax 2020-03-06 16:41:26 +01:00
Philipp Wolfer
062e75afb8 Test saving license to ID3 2020-03-06 13:47:38 +01:00
Philipp Wolfer
6e8f4ed5d2 Improve format test coverage 2020-03-06 13:47:38 +01:00
Philipp Wolfer
83be0ae5a3 Added tests for loading unsupported images from tags 2020-03-06 12:46:30 +00:00
Bob Swift
d5de2dc159 Use StackItem and FunctionStackItem with script exception calls 2020-03-05 15:35:16 -07:00
Laurent Monin
053f57666a _CAA_THUMBNAIL_SIZE_MAP: use '500' instead of historical 'large' for thumbnail URLs 2020-03-05 15:49:20 +01:00
Laurent Monin
9c261325fe _CAA_THUMBNAIL_SIZE_MAP: use '250' instead of historical 'small' for thumbnail URLs 2020-03-05 15:46:56 +01:00
Laurent Monin
2529d98151 caa_url_fallback_list(): add support for size aliases
It makes it more future-proof, and we'll let us use 500 and 250 instead of historical large and small
Add/modify related tests
2020-03-05 15:43:12 +01:00
Laurent Monin
4892309e95 test_caa_url_fallback_list(): add few explanations 2020-03-05 15:32:54 +01:00
Laurent Monin
ac84aba3a2 test_caa_url_fallback_list(): Improve assertion error message 2020-03-05 15:31:22 +01:00