Commit Graph

126 Commits

Author SHA1 Message Date
Philipp Wolfer
b273b116ca PICARD-2616: Add tests for releasedate tag 2023-05-22 20:46:45 +02:00
Philipp Wolfer
0b823f2443 PICARD-2535: Strip trailing null chars for Vorbis / FLAC 2023-04-18 11:16:48 +02:00
Philipp Wolfer
75871991b8 PICARD-2595: Customizable replacement for directory separators 2022-12-06 09:37:45 +01:00
Philipp Wolfer
cb339c6a4a PICARD-356: Allow user defined replacements for Windows incompatible characters 2022-12-05 17:08:56 +01:00
Philipp Wolfer
95c736a13e PICARD-2553: Add option to use underscores instead of spaces in file naming
This collapses multiple whitespace characters and underscores in a filename into a single underscore
2022-12-04 18:07:42 +01:00
Philipp Wolfer
76c2dff6b6 Fixed proper bitrate in WAVE tests
mutagen < 1.46 reports the wrong bitrate for WAVE files. Test the proper bitrate in this version, don't test the bitrate in earlier versions.
2022-10-10 12:08:10 +02:00
Philipp Wolfer
1853572a99 Replace some list usages with tuples, sets or iterators 2022-04-13 10:17:22 +02:00
Philipp Wolfer
5037ce9935 PICARD-2076: Allow ignoring the Windows filepath limit when renaming files 2022-03-08 14:00:24 +01:00
Philipp Wolfer
f20e47ae77 PICARD-2411: Remove Flac seektable if it has no seekpoints
A missing seektable is valid. Removing an otherwise empty seektable fixes the issues with software that cannot handle empty seektables.

Fully reconstructing a seek table would require decoding the Flac data.
2022-02-11 15:01:51 +01:00
Philipp Wolfer
f94c725f50 PICARD-2411: Flac seektable tests 2022-02-11 15:01:51 +01:00
Laurent Monin
2f6479747d Update headers 2022-02-07 09:41:57 +01:00
Marcin Szalowicz
fa2e443021 Add option to fix seektable for flac files
This is to fix problem with Kodi which is unable to load files
that have empty SeekTable, so by default a single SeekPoint is added.
An error message is logged if the file has no samples.
2022-02-05 17:51:00 +01:00
Philipp Wolfer
0983c9531d Set log level in tests to DEBUG
This allows pytest to capture the log output and display it in context of the test.d
2022-01-19 08:11:33 +01:00
Laurent Monin
820551d513 Move FILE_INFO_TAGS to File class and reduce code redundancy
- add a test for File._copy_file_info_tags()
2022-01-04 12:00:19 +01:00
Philipp Wolfer
a25a6fd0aa Fixed headers with fix-header.py 2021-12-21 08:38:20 +01:00
Philipp Wolfer
a4e5c7ed42 PICARD-2346: Fix ID3v2.3 files showing changes with identical tags
Fixes a regression introduced in a5fcde to optimize display of format specific metadata
2021-12-04 17:05:31 +01:00
Philipp Wolfer
1c566ca08c PICARD-2342: Fix saving MP4 and ASF files with "clear tags" and "preserve images"
Saving MP4 or ASF files failed if the files do not have existing embedded cover art and both "clear existing tags" and "keep embedded images when clearing tags" are active.
2021-11-27 15:06:39 +01:00
Philipp Wolfer
543709eab2 Various minor code cleanups
- Use generator comprehension where possible
- Prefer dict comprehension over dict([...])
- General code cleanup
2021-11-26 08:00:43 +01:00
Laurent Monin
14ce07756e Update Copyright headers, with the help of fix-headers.py script 2021-11-10 21:38:54 +01:00
Philipp Wolfer
d8406b5159 PICARD-2324: Move .wvc files before moving additional files 2021-11-09 11:02:34 +01:00
Philipp Wolfer
7cab070f74 PICARD-2324: Fix renaming of WavPack correction files 2021-11-09 08:51:25 +01:00
Philipp Wolfer
dd80c1d078 Use set comprehension where appropriate 2021-11-07 10:08:14 +01:00
Philipp Wolfer
aed015c657 Use sets in apev2 tests 2021-10-31 15:29:32 +01:00
Philipp Wolfer
cb6973cf44 Use sets instead of lists in conditionals 2021-10-31 10:17:23 +01:00
Philipp Wolfer
72f7d0ed18 Use sets for format unsupported tags 2021-10-31 09:56:14 +01:00
Laurent Monin
7c133891bd Merge pull request #1933 from phw/PICARD-2314-fix-mp4-freetext-length
PICARD-2314: Fix ~length getting written to MP4 ----:com.apple.iTunes:~length
2021-10-31 09:43:59 +01:00
Philipp Wolfer
d5f131da04 PICARD-2307: Fix ValueError for Vorbis when deleting invalid tags 2021-10-29 18:13:47 +02:00
Philipp Wolfer
7a37e25152 vorbis: empty string is not a valid Vorbis comment key 2021-10-29 18:13:47 +02:00
Philipp Wolfer
b7179d36fc Move ID3 image type functions to picard.coverart.utils 2021-10-29 18:13:16 +02:00
Philipp Wolfer
a7f0a27f92 Exclude technical variables like ~length from format supported tags
Those values are taken from technical format information and are not part of the tags. This also fixes ~length getting written to MP4 (PICARD-2314).
2021-10-29 00:11:02 +02:00
Philipp Wolfer
c059631723 Add Id3Encoding enum 2021-10-04 10:46:57 +02:00
Philipp Wolfer
f5f03a1f00 PICARD-2199: Fix saving ratings to ID3 with non-latin1 characters in email 2021-10-04 08:53:52 +02:00
Philipp Wolfer
ee06ed20f3 PICARD-2263: Save performers without role to TMCL / TIPL 2021-08-21 18:14:01 +02:00
Philipp Wolfer
6d0a052506 PICRD-257: Added format specific tests for preserve_images
Testing special handling in Vorbis and APEv2 files.
2021-06-16 08:52:55 +02:00
Philipp Wolfer
a3ebc1cb22 PICARD-257: Add option to exclude embedded images from clear_existing_tags 2021-06-16 08:52:55 +02:00
Bob Swift
3764518d7f Fix tests. 2021-06-13 17:45:21 -06:00
Philipp Wolfer
626a080254 PICARD-2174: Provide settings to File.format_specific_metadata
Allows for optimizations without having to read the settings from config on each invocation.
2021-04-30 11:43:37 +02:00
Sophist
a5fcde1dd3 PICARD-2174: Optimize implementation to display format specific metadata 2021-04-30 11:43:37 +02:00
Philipp Wolfer
dc1f46946e PICARD-2135: Fixed overwriting and deleting license tags to ID3 2021-03-09 10:30:10 +01:00
Philipp Wolfer
09d771906f PICARD-2135: Fixed overwriting and deleting WOAR frame 2021-03-09 09:16:29 +01:00
Philipp Wolfer
dee1ad5c81 PICARD-1998: Add "director" (for videos) tag
This adds a tag "director" which is filled with the "video director" AR from MB by default.
2021-01-16 15:48:53 +01:00
Philipp Wolfer
c0e6243a13 PICARD-1926: Adjust test cases for new config structure 2020-12-25 12:37:15 +01:00
raingloom
5b37bfc33a Minor fix ID3 rename_txxx_tags test 2020-09-06 20:56:40 +02:00
Philipp Wolfer
dd2acaf6ee PICARD-1892: Fixed deleting totaldiscs / totaltracks from Vorbis tags
Deleting failed if the file only contained disctotal or tracktotal tags, but not also totaldiscs or totaltracks.
2020-07-20 13:29:54 +02:00
Philipp Wolfer
bbc3f1450f PICARD-1839: Support tagging DSDIFF (DFF) files with ID3 2020-07-14 07:41:15 +00:00
Philipp Wolfer
df8010cf02 PICARD-1826: Consider .ogg files as generic Ogg container files
Fixes e.g. loading Ogg Opus files with .ogg extension, instead of assuming .ogg is always Ogg Vorbis.
2020-05-24 16:34:38 +02:00
Philipp Wolfer
651bbad60d Merge pull request #1534 from phw/PICARD-1812-riff-info
PICARD-1812: Save RIFF INFO tags for WAVE
2020-05-13 19:11:08 +02:00
Philipp Wolfer
d79d142a04 Refactor picard.formats and picard.coverart.providers to avoid circular dependencies 2020-05-13 17:04:11 +02:00
Philipp Wolfer
bb7c45ddf8 PICARD-1812: Tests for loading / saving RIFF INFO tags 2020-05-13 13:50:05 +02:00
Philipp Wolfer
1542d4d7c0 PICARD-1812: Option to remove RIFF INFO from WAVE files 2020-05-13 11:08:07 +02:00