fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2026-02-19 06:03:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,408 Commits 1 Branch 0 Tags
a662a67334ce6d2cf7f3078110f3bbdc9f481f45
Commit Graph

684 Commits

Author SHA1 Message Date
raingloom
5b37bfc33a Minor fix ID3 rename_txxx_tags test 2020-09-06 20:56:40 +02:00
Philipp Wolfer
75ec812f6b Avoid the terms "blacklist" and "whitelist" 2020-09-06 19:07:27 +02:00
Philipp Wolfer
81b88101eb Rename Whitelist cover art provider to UrlRelationships 2020-09-06 19:07:27 +02:00
Philipp Wolfer
da1acd36c2 Added missing test for config upgrade to v2.4.0b3 2020-09-05 18:30:11 +02:00
Laurent Monin
9aaa5c62a8 Merge pull request #1596 from zas/fix_pr_1891 
PICARD-1891: handle incorrect date parsing exceptions
 2020-07-21 13:19:24 +02:00
Laurent Monin
5e5535a21b Test for ID3 date format 2020-07-21 09:39:21 +02:00
Philipp Wolfer
615426449f PICARD-1894: Fix tracknumber detection from filename 
Do not detect parts of longer numbers as track no., e.g. "Song 2015" must not be detected as track no. 15.
 2020-07-21 09:37:24 +02:00
Laurent Monin
219b734569 PICARD-1891: handle incorrect date parsing exceptions 
- catch exceptions in extract_year_from_date() and log them to debug
- return None if year cannot be extracted
- check for None in metadata.compare_to_release_parts() before trying to compare years

This isn't perfect, the function is called a lot of time and it spams debug log (if enabled)

Note: I removed a very old comment in imports that doesn't make any sense (it was introduced 6 years ago in 323d12892c) and it was making isort unhappy.
 2020-07-20 17:41:46 +02:00
Philipp Wolfer
dd2acaf6ee PICARD-1892: Fixed deleting totaldiscs / totaltracks from Vorbis tags 
Deleting failed if the file only contained disctotal or tracktotal tags, but not also totaldiscs or totaltracks.
 2020-07-20 13:29:54 +02:00
Philipp Wolfer
048651fa41 Refactor script module into package 2020-07-19 21:30:56 +02:00
Laurent Monin
dc782a6b43 Fix spurious Restart Picard message about color changes 
- detection of color changes was broken
- code cleanup
- added tests
 2020-07-19 16:10:26 +02:00
dukeyin
cbc1bce030 Add unit test for "Use release relationships" 
* Added a release-level producer to release.json because the existing release-artist relationships are not used in tagging
* Modified the existing release test to check that the producer tag is the release-level producer when "Use release relationships" is enabled
* Added a release test to check that the producer tag is empty when "Use release relationships" is disabled
 2020-07-17 20:01:37 -04:00
dukeyin
f042928433 Don't use release relationships if they are disabled in metadata options 2020-07-17 19:57:37 -04:00
Philipp Wolfer
98b0f327b2 PICARD-1871: Use TagListEditor for preserved tags 2020-07-14 17:04:51 +00:00
Philipp Wolfer
3f9ad5a743 PICARD-1884: Fix tracknumber tag with value 0 not set 2020-07-14 17:03:30 +00:00
Philipp Wolfer
bbc3f1450f PICARD-1839: Support tagging DSDIFF (DFF) files with ID3 2020-07-14 07:41:15 +00:00
Philipp Wolfer
a2207df8ba PICARD-1853: Fix crash in natsort on superscript numeric chars 2020-06-25 18:18:12 +02:00
Philipp Wolfer
b0a01a99ac PICARD-1853: Fix natsort crashing on strings with '\0' 2020-06-23 20:18:05 +02:00
Philipp Wolfer
cbe88786a6 PICARD-1846: Do not raise KeyError in Metadata.unset 2020-06-19 14:47:03 +02:00
Philipp Wolfer
ddd9c9d4d9 Merge pull request #1555 from Gabrielcarvfer/Performance 
PICARD-1844: Further improve loading and clustering performance
 2020-06-19 08:37:57 +02:00
Gabriel Ferreira
e843b4f3ed Update statusbar with clustering progress 2020-06-18 14:33:57 -03:00
Philipp Wolfer
149e02c914 PICARD-1840: For instrumental recordings unset lyricist 
Also set language to zxx ("No lyrics"), fixes PICARD-1117
 2020-06-17 21:34:02 +02:00
Philipp Wolfer
8cea3807c0 PICARD-1820: Allow single digit versions like "2" to be parsed 
A version 2 is equivalent to 2.0 or 2.0.0.
 2020-06-08 18:22:32 +02:00
Philipp Wolfer
df8010cf02 PICARD-1826: Consider .ogg files as generic Ogg container files 
Fixes e.g. loading Ogg Opus files with .ogg extension, instead of assuming .ogg is always Ogg Vorbis.
 2020-05-24 16:34:38 +02:00
Philipp Wolfer
419ff87fea PICARD-1807: Fix error handling when using python-libdiscid 
discid.disc.DiscError only exists in python-discid, not in the compat version of python-libdiscid. The proper way in both libraries is to access discid.DiscError.
 2020-05-13 19:12:16 +02:00
Philipp Wolfer
651bbad60d Merge pull request #1534 from phw/PICARD-1812-riff-info 
PICARD-1812: Save RIFF INFO tags for WAVE
 2020-05-13 19:11:08 +02:00
Philipp Wolfer
d79d142a04 Refactor picard.formats and picard.coverart.providers to avoid circular dependencies 2020-05-13 17:04:11 +02:00
Philipp Wolfer
bb7c45ddf8 PICARD-1812: Tests for loading / saving RIFF INFO tags 2020-05-13 13:50:05 +02:00
Philipp Wolfer
1542d4d7c0 PICARD-1812: Option to remove RIFF INFO from WAVE files 2020-05-13 11:08:07 +02:00
Philipp Wolfer
b8644aad3d PICARD-1812: Options for saving RIFF INFO to WAVE 2020-05-13 11:08:07 +02:00
Philipp Wolfer
0996495cee PICARD-1128: Allow tagging WAVE files with ID3 
Requires support in mutagen
 2020-05-13 11:06:37 +02:00
Laurent Monin
a308c39343 preprocessor -> postprocessor 
Suggested by @phw
 2020-05-13 11:05:11 +02:00
Laurent Monin
7ec406f8bd Display module for script functions registered outside picard 2020-05-13 11:05:10 +02:00
Laurent Monin
06c2618232 Improve script function documentation formatting, using dl/dt/dd html tags 
Make color of the first line configurable (demo mode)
 2020-05-13 11:05:10 +02:00
Laurent Monin
66632e9761 Sort script functions documentation 2020-05-13 11:05:10 +02:00
Laurent Monin
d52bfd83b1 Make markdown module optional, fix tests accordingly 2020-05-13 11:05:09 +02:00
Laurent Monin
b284c841c4 Also test FunctionRegistryItem() 2020-05-13 11:05:09 +02:00
Laurent Monin
7d0e185a85 Fix up script function documentation tests 
- ensure registry is empty
- use actual html code as returned by markdown
- split code among different test methods
 2020-05-13 11:05:09 +02:00
Laurent Monin
7508cbf743 Reduce code redundancy, add helpers assertStartswith() and assertEndswith() 2020-05-13 11:05:09 +02:00
Laurent Monin
310bed488a Add script_function_documentation_all() to dump all script functions documentation 2020-05-13 11:05:09 +02:00
Laurent Monin
a7680bf75e script_function_documentation(): returns function doc in wanted format, add tests 2020-05-13 11:05:09 +02:00
Philipp Wolfer
fb83a8e76b Enable flake8 E265: Block comment should start with '# ' 
Most changes involve replacing non-breaking space with a simple space after the #.
 2020-05-13 11:03:13 +02:00
Philipp Wolfer
909ea667b8 Check code style of tests with flake8 2020-05-13 11:03:13 +02:00
Philipp Wolfer
ee8b88cf2a Avoid using ambiguous variable name "l" 
Fixes the issue E741 reported by flake8 >= 3.8.
https://www.flake8rules.com/rules/E741.html
 2020-05-12 19:33:13 +02:00
Philipp Wolfer
a3bb51993f PICARD-1813: Fixed calling $title with empty value 2020-05-09 10:46:57 +02:00
Philipp Wolfer
ac91895629 PICARD-1803: Fixed decamelcasing relationship attributes 
EWI must not become E W I
 2020-04-17 22:02:10 +02:00
Undearius
df85263762 PICARD-1800: Simplify Unicode 'Bullet' to ASCII 'Hyphen-minus' 2020-03-29 12:45:15 +02:00
Philipp Wolfer
f812681092 PICARD-1795: Allow deleting iTunNORM and iTunPGAP tags from ID3 2020-03-28 20:01:58 +00:00
Ray
afcab0f779 Parse additional fields from the AcoustId response 2020-03-18 08:41:04 +00:00
Laurent Monin
04a98581a3 Merge pull request #1514 from rdswift/fix_function_location_info_and_add_to_runtimeerror_tests 
Fix function line, column in ScriptRuntimeError.  Add tests.
 2020-03-07 01:19:16 +01:00