skelly37
cb714d7cf6
timeout included
2022-06-22 19:52:59 +02:00
skelly37
fb2cb75d92
fixed commit
2022-06-21 18:14:51 +02:00
skelly37
c0c5074297
my last idea
2022-06-21 10:22:25 +02:00
skelly37
46c88fb567
fallback used, filename tests removed, should work fine
...
I've decided to remove the filename tests becaue they provide no useful value during the tests. Everything has to be mocked and so on... Debug-logging the pipe path should do, because during the tests we cannot be 100% sure that the specific folder will be writable, the env variable will be declared etc.
2022-06-21 08:44:28 +02:00
skelly37
8b30c2e858
missed call
2022-06-16 11:31:43 +02:00
skelly37
b83ce3f2d8
NoneType guard, defaulting to /tmp
2022-06-16 11:29:15 +02:00
skelly37
2de7543f31
added mocking for filename generation tests
2022-06-16 11:02:51 +02:00
skelly37
5f27781635
os-specific filename tests with decorators
2022-06-15 21:13:40 +02:00
skelly37
d029a9d824
better logger, tuple split into lines
2022-06-15 08:54:43 +02:00
skelly37
83bbdb3e18
fallback path generates warn, tests descriped where appliable, path is tested
2022-06-14 19:34:27 +02:00
skelly37
6782ddf0c5
suggestions included, minor refactor
2022-06-14 18:56:58 +02:00
skelly37
aa8233bf1d
codacy
2022-06-14 17:49:49 +02:00
skelly37
f66e47b5a0
pipe reads&sends lists now, the whole protocol is tested
2022-06-14 17:42:08 +02:00
skelly37
904824e3dc
started writing test cases, app_name and app_version in pipe are forced to be str
2022-06-13 11:19:32 +02:00
Philipp Wolfer
bfeabb7ba8
PICARD-2475: Fix "Lookup in browser" in search dialogs
...
If the search in the dialog contained a MBID, the "Lookup in browser" button would attempt to load this MBID as album / recording instead of opening the browser. Now force opening in browser.
2022-05-09 13:12:11 +02:00
Philipp Wolfer
d7b80547a4
PICARD-2470: Allow utf-16 encoded EAC log files
...
EAC seems to save UTF-16 encoded files. There circulate TOC files in UTF-8 encoding, but mostly these are probably the result of copy and pasting the log.
Detect the encoding based on the BOM (which for UTF-16 should always be present).
2022-05-08 12:44:45 +02:00
Philipp Wolfer
25d58f2660
Merge pull request #2101 from phw/PICARD-2415-other-versions-dialog
...
PICARD-2415: Show other release versions in search dialog
2022-05-01 14:35:22 +02:00
Philipp Wolfer
c40f10a04f
Simplify album and track similarity search
...
Reuse existing search functonality, de-duplicate code.
2022-05-01 14:34:49 +02:00
Philipp Wolfer
2360c2db0e
PICARD-2415: Allow searching and switching "other versions" in separate dialog
...
The submenu ist still displayed for quick selection, but a "Show more details..." menu option allows selecting a different version in a search dialog.
2022-05-01 12:09:36 +02:00
Philipp Wolfer
1853572a99
Replace some list usages with tuples, sets or iterators
2022-04-13 10:17:22 +02:00
Philipp Wolfer
dc9185664b
Merge pull request #2090 from phw/huge-release-performance
...
PICARD-2454: Improve performance when handling releases with many tracks
2022-04-10 12:16:15 +02:00
Philipp Wolfer
5e340c84c6
Merge pull request #2086 from rdswift/remove_zero-width_spaces_from_output_file_paths
...
PICARD-2451: Remove unicode zero-width space characters from file path
2022-04-09 20:26:11 +02:00
Philipp Wolfer
70b07bc570
PICARD-2454: Stop metadatabox updates while moving files
2022-04-09 18:26:59 +02:00
Philipp Wolfer
797b296396
Optimize access to profile settings
...
On every settings read / write access the list of profile setting names got compiled again. This list does not change on runtime, so instead compute it only once.
2022-04-09 16:54:52 +02:00
Bob Swift
d73a3dd0d8
Add test.
2022-04-07 10:35:42 -06:00
Philipp Wolfer
aaee5e4f37
PICARD-993: Have different error icons for different file errors
...
Separate icons for file not found, access denied and anything else
2022-03-12 10:28:42 +01:00
Philipp Wolfer
0ff523db9d
PICARD-2076: Added tests for picard.util.system_supports_long_paths
2022-03-08 15:21:00 +01:00
Philipp Wolfer
718875177b
PICARD-2076: Use Windows long path prefix only, if long paths are unsupported
2022-03-08 14:00:24 +01:00
Philipp Wolfer
5037ce9935
PICARD-2076: Allow ignoring the Windows filepath limit when renaming files
2022-03-08 14:00:24 +01:00
Philipp Wolfer
c04f143274
PICARD-1570: Allow loading files with long paths on Windows
2022-03-07 11:18:49 +01:00
Philipp Wolfer
e1c6234dd7
Have find_best_match and sort_by_similarity accept any iterable
2022-02-17 08:18:26 +01:00
Philipp Wolfer
f6d3990a05
PICARD-2422: Added config upgrade for cleaning toolbar_layout
2022-02-16 18:16:47 +01:00
Philipp Wolfer
aeb1a7d5a8
PICARD-2422: Remove all AcousticBrainz extraction and submission code
2022-02-16 18:16:46 +01:00
Philipp Wolfer
e9c6df2d3e
Implement __bool__ and __repr__ for AcoustID Submission
...
Implementing __bool__ avoids checks like "if submission" to use __len__.
2022-02-14 09:55:40 +01:00
Philipp Wolfer
88e7766e5e
Added test for AcoustID Submission.args without MBID
2022-02-14 08:38:43 +01:00
Philipp Wolfer
f20e47ae77
PICARD-2411: Remove Flac seektable if it has no seekpoints
...
A missing seektable is valid. Removing an otherwise empty seektable fixes the issues with software that cannot handle empty seektables.
Fully reconstructing a seek table would require decoding the Flac data.
2022-02-11 15:01:51 +01:00
Philipp Wolfer
f94c725f50
PICARD-2411: Flac seektable tests
2022-02-11 15:01:51 +01:00
Philipp Wolfer
8b8593b546
PICARD-2414: Added some additional tests for tracknum_and_title_from_filename
...
Test some more real world examples and ignore cases like UB40 where a no. follows directly on alphanumeric characters.
2022-02-11 11:01:33 +01:00
Laurent Monin
2f6479747d
Update headers
2022-02-07 09:41:57 +01:00
Marcin Szalowicz
fa2e443021
Add option to fix seektable for flac files
...
This is to fix problem with Kodi which is unable to load files
that have empty SeekTable, so by default a single SeekPoint is added.
An error message is logged if the file has no samples.
2022-02-05 17:51:00 +01:00
Laurent Monin
203933ff9f
Add few tests for translate_artist_names_script_exception
2022-02-03 10:31:54 +01:00
Philipp Wolfer
9e740c11a4
Omit standard ports in URLs constructed by build_qurl
2022-01-31 07:49:21 +01:00
Philipp Wolfer
803055a9f9
PICARD-2410: Implement parsing Whipper ripping log files
2022-01-30 15:34:17 +01:00
Philipp Wolfer
3ae6706b05
Moved calculate_mb_toc_numbers to picard.disc.utils
2022-01-30 15:34:17 +01:00
Philipp Wolfer
eeed3adb4d
Test all methods in FileLookup
2022-01-28 08:16:45 +01:00
Philipp Wolfer
d89c14d3ea
Support all MB entity URLs in FileLookup
2022-01-28 08:16:44 +01:00
Philipp Wolfer
97a272bd3a
Added tests for FileLookup.mbid_lookup
2022-01-28 08:16:44 +01:00
Philipp Wolfer
17b8c9b6ac
PICARD-2409: Search for cdtoc URL triggers CD lookup
2022-01-27 09:21:26 +01:00
Laurent Monin
0761263c4d
Use tuples instead of lists, since those aren't to be modified
2022-01-25 12:53:56 +01:00
Philipp Wolfer
6f9c70951d
Moved old disc module and eaclog to disc package
...
Avoids name conflict and confusion of picard.discid with the discid pip package.
2022-01-25 08:38:15 +01:00
