Commit Graph

316 Commits

Author SHA1 Message Date
Philipp Wolfer
3da76f97ae PICARD-1354: Adressed code review comments 2018-09-25 15:43:52 +02:00
Philipp Wolfer
96c7f2f082 PICARD-1354: Allow using instruments and vocals as credited 2018-09-25 15:07:33 +02:00
Philipp Wolfer
3a380e2355 PICARD-1162: Fix solo attribute for vocals / instruments (#979) 2018-09-22 10:37:49 +02:00
Philipp Wolfer
82d5c0ffe1 PICARD-1346: Added unit test 2018-09-19 21:25:26 +02:00
Laurent Monin
16a3074be4 PEP8 fixes 2018-09-13 17:54:13 +02:00
Laurent Monin
683b934685 Drop use of string_(), deprecated 2018-09-08 15:48:24 +02:00
Philipp Wolfer
97bd392844 PICARD-1112: Clear deleted tags after saving file 2018-09-07 13:18:19 +02:00
Philipp Wolfer
9bd2e9418d Merge pull request #959 from phw/PICARD-1336-mp4-set-bool-tags-supported
PICARD-1336: For MP4 integer tags were not marked as supported
2018-09-06 16:51:04 +02:00
Philipp Wolfer
6d679e9e46 Merge pull request #954 from phw/PICARD-1332-restore-deleted-file-tags
PICARD-1332: When unmatching a file restore deleted tags from origina…
2018-09-06 14:16:17 +02:00
Philipp Wolfer
cb0f391c12 PICARD-1336: For MP4 integer tags were not marked as supported 2018-09-06 14:12:47 +02:00
Laurent Monin
9bdc435dcb Clean-up imports with the help of isort 2018-09-05 17:39:25 +02:00
Philipp Wolfer
52827ae058 PICARD-875: Make compatid3 tags available to AIFF and DSF 2018-09-05 14:41:27 +02:00
Laurent Monin
db3bae8ba2 Merge branch 'master' into PICARD-1332-restore-deleted-file-tags 2018-09-05 09:05:27 +02:00
Laurent Monin
63d61c7830 Merge branch 'master' into PICARD-1328-fix-load-optimfrog 2018-09-05 08:38:53 +02:00
Philipp Wolfer
cc93a2a45f PICARD-1332: Deleted tags on tracks get applied to matched files 2018-09-05 08:33:19 +02:00
Philipp Wolfer
870b159e22 Added unit tests for APE, ASF, Opus and Speex formats 2018-09-04 11:33:09 +02:00
Philipp Wolfer
182ea65b3f PICARD-1328: Fix OptimFROG format detection 2018-09-04 08:47:03 +02:00
Philipp Wolfer
4c20e811cf PICARD-1329: Fix saving iTunNORM tags to ID3 2018-09-04 07:46:14 +02:00
Philipp Wolfer
9c649d97f0 PICARD-1328: Fix loading OptimFROG files 2018-09-03 23:26:53 +02:00
Philipp Wolfer
0e55d039c1 PICARD-1327: Fix loading TAK files 2018-09-03 17:42:12 +02:00
Philipp Wolfer
30895eedd6 FLAC: Preserve waveformatextensible_channel_mask when clearing tags
Fixes PICARD-1326
2018-09-03 15:07:57 +02:00
Bob Swift
3af25fdff6 PICARD-1045: Add program update checking 2018-08-29 17:19:08 +02:00
Philipp Wolfer
2fbe8f97a3 PICARD-803: ASCII replacements can cause folder creation 2018-08-27 23:01:57 +02:00
Philipp Wolfer
002cf52dea Tests: Reduced redundancy in formats tests 2018-08-25 09:34:10 +02:00
Philipp Wolfer
38fa2b0adc Tests: Settings cleanup is not needed
A fresh copy of settings is assigned on setUp
2018-08-25 09:14:59 +02:00
Philipp Wolfer
3c9adf34a0 PICARD-1245: Added tests 2018-08-24 17:31:12 +02:00
Laurent Monin
5329e3592a Clean up and sort imports using isort
Add a config for isort (https://github.com/timothycrosley/isort)
Run isort -rc . and make import style consistent across files
Add a note about `isort` in CONTRIBUTING.md
2018-08-22 08:51:25 +02:00
Antonio Larrosa
2eb01c2063 Add a test that checks move_additional_files work with unicode paths
This is to test PICARD-1207
2018-08-08 14:59:33 +05:30
Wieland Hoffmann
60588b6c3e PICARD-1277 (workaround): translate_caa_type: Return the input if the type is unknown
That can happen if a new cover art type is added in MB that Picard doesn't yet
know about. Instead of raising a KeyError (and crashing), just return the raw
type, which is good enough until we have something better to show.
2018-07-03 18:02:27 +02:00
Sambhav Kothari
19940ee8ef Refactor format tests to remove unsupported tags automatically 2018-02-28 13:57:54 +05:30
Laurent Monin
a678d540dc Add DSF test 2018-02-26 14:10:24 +01:00
Laurent Monin
374849faef PICARD-1187: Add DSF file support 2018-02-26 14:08:48 +01:00
Laurent Monin
940b216f09 Drop useless wrapper 2018-02-26 13:33:08 +01:00
Laurent Monin
a8e2d39271 Introduce a simple decorator and reduce code redundancy 2018-02-26 12:48:38 +01:00
Laurent Monin
28bcf6535d Reduce code redundancy: use addCleanup(), get rid of tearDown() 2018-02-26 12:31:17 +01:00
Laurent Monin
9f8ea36c95 Remove left-over debug code 2018-02-26 12:11:11 +01:00
Laurent Monin
442331cf6c Wrap common test classes in CommonTests to prevent unittest to pick tests in those 2018-02-26 12:11:11 +01:00
Laurent Monin
6a5ef767d2 Raise SkipTest where appropriate, instead of silently returning
- replace `original` with more explicit `testfile`
- build the full path once
- extract extension and store it in a property
2018-02-26 00:26:12 +01:00
Laurent Monin
00ea9375ae Do not repeat tags declaration, just modify one dict depending on format
Provides few methods:
- FormatsTest.setup_tags()
- FormatsTest.set_tags()
- FormatsTest.remove_tags()
2018-02-25 23:52:34 +01:00
Laurent Monin
e2ed569233 Python3 doesn't need to import print_function
This is now a standard feature and no longer needs to be imported from __future__.

https://www.python.org/dev/peps/pep-3105/
2018-02-05 14:43:55 +01:00
Laurent Monin
8df1e78af4 Move throttling code to its own file
API is modified to use methods to get/set delays, instead of setting global variables
2018-01-29 18:24:56 +01:00
Laurent Monin
90ce834eab Use Python3 super()
https://www.python.org/dev/peps/pep-3135/
https://docs.python.org/3.5/library/functions.html#super
https://rhettinger.wordpress.com/2011/05/26/super-considered-super/
2018-01-26 09:18:59 +01:00
Laurent Monin
7a36f8c5f4 Sort dicts by key so it is easier to find something 2018-01-25 18:40:45 +01:00
Laurent Monin
136e3a9e7a Remove duplicate key 'artist' in tags dicts
This is there since 10 years, appeared with cfe5299a76
2018-01-25 18:34:04 +01:00
Laurent Monin
2f1e58c56e Remove duplicate key 'album' in tags dicts
This is there since 10 years, appeared with cfe5299a76
2018-01-25 18:31:39 +01:00
Wieland Hoffmann
c18ae092ba Fix length_score and add tests
In 2f8496e, 1.0 - ... turned into 0.0. Fix that.
2018-01-18 20:58:32 +01:00
Wieland Hoffmann
8490422384 PICARD-1159: Don't pass filenames as bytes to wave.open
wave.open treats everything that's not a str as a file-like object.
encode_filename returns bytes, but they're not file-like.
2017-12-06 19:19:34 +01:00
Sambhav Kothari
b0d412169c Add null type tests 2017-07-26 16:12:12 +05:30
Sambhav Kothari
844eca9eaa Fix null type errors and add test data for null types 2017-07-26 16:09:34 +05:30
Laurent Monin
4f328dba79 LabelInfoTest: reduce code redundancy 2017-07-25 15:48:47 +02:00