fergalmoran/picard
1
0
Fork 0
mirror of https://github.com/fergalmoran/picard.git synced 2025-12-22 09:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,272 Commits 1 Branch 0 Tags
d375fc17930e1c1938f86d40b529a11dd5fa47d0
Commit Graph

60 Commits

Author SHA1 Message Date
Laurent Monin
af6f90d64a PICARD-2700: fix accumulating series metadata on refresh 2023-08-22 14:20:18 +02:00
Laurent Monin
ee76bf9e51 Improve coverage of artist_to_metadata(), checking for ended/endarea/enddate 
- drop redundant test
 2023-06-02 15:47:16 +02:00
Laurent Monin
a962f9176e Improve coverage of media_formats_from_node() and medium_to_metadata() 
- use a multi-media release (this case wasn't tested at all)
- fuse old and new tests
- drop media.json test file as it was only used there
 2023-06-02 15:26:53 +02:00
Laurent Monin
2060e3bc82 Add tests for _relations_to_metadata_target_type_url() 
- 100% coverage of this method
 2023-06-02 11:40:00 +02:00
Laurent Monin
2ae3b54614 Basic tests for _parse_attributes() 2023-06-02 10:59:18 +02:00
Laurent Monin
c82ef8b0f1 Extensively test _locales_from_aliases() 
- use a stripped down version of aliases (unused fields were removed)
- 100% coverage
- correctness of results has to be reviewed
 2023-06-02 00:45:40 +02:00
Philipp Wolfer
26cf9b507e PICARD-711: Add support for series variables 
Adds support for variables for release group, release, recording
and work series. The following variables are getting set:

- ~recording_series
- ~recording_series_id
- ~recording_seriescomment
- ~recording_seriesnumber
- ~release_series
- ~release_series_id
- ~release_seriescomment
- ~release_seriesnumber
- ~releasegroup_series
- ~releasegroup_series_id
- ~releasegroup_seriescomment
- ~releasegroup_seriesnumber
- ~work_series
- ~work_series_id
- ~work_seriescomment
- ~work_seriesnumber
 2023-05-29 21:42:42 +02:00
David Kellner
2055b05d9a PICARD-2606: Add writer and lyricist sort names as variables 2023-01-07 23:00:08 +01:00
Philipp Wolfer
84f1092ff7 PICARD-2507: Include pregap track in medium's totaltracks count 2022-06-26 18:14:22 +02:00
Laurent Monin
2f6479747d Update headers 2022-02-07 09:41:57 +01:00
Laurent Monin
203933ff9f Add few tests for translate_artist_names_script_exception 2022-02-03 10:31:54 +01:00
Philipp Wolfer
59ffd90f88 PICARD-2292: Fix detecting instrumnetal for multi-work recordings 
A recording with multiple works should only get the language set to "no lyrics" if all performances are instrumental
 2022-01-23 18:04:18 +01:00
Philipp Wolfer
a25a6fd0aa Fixed headers with fix-header.py 2021-12-21 08:38:20 +01:00
Laurent Monin
ac57f95d92 Introduce _node_skip_empty_iter() to reduce code redundancy 2021-11-27 19:54:18 +01:00
Laurent Monin
7f00f523ad Improve coverage 2021-11-26 15:21:38 +01:00
Laurent Monin
14ce07756e Update Copyright headers, with the help of fix-headers.py script 2021-11-10 21:38:54 +01:00
Philipp Wolfer
7fabde2edf PICARD-2288: Add a variable ~workcomment for the work disambiguation 2021-10-07 14:38:59 +02:00
Philipp Wolfer
192db0a729 PICARD-2233: Composer "credited as" must not overwrite composersort 
If "credited as" is set on a composer relationship, the credited name gets used both for composer and composersort. This is inconsistent with how target credits get used for artist / artistsort and causes a composersort tag without proper sort name.
 2021-09-12 19:40:49 +02:00
Bob Swift
8a4082fee7 Revise artist name translation logic. Add tests. 2021-09-09 12:34:34 -06:00
Bob Swift
3e5b060a37 Add ability to use multiple translation locales: 
- Add new `artist_locales` setting and remove old `artist_locale`.
- Add new translation locales selector and ordering screen.
- Cycle through selected translation locales until a match is found.
- Update tests.
 2021-09-08 17:47:16 -06:00
Vladislav Karbovskii
7224961bc4 PICARD-157: Option to skip artist name translation for specific scripts 
Add a dropdown to select a script for which artist translation will be skipped.

Co-authored-by: Laurent Monin <github@norz.org>
Co-authored-by: Bob Swift <bswift@rsds.ca>
 2021-09-06 12:00:01 +02:00
Philipp Wolfer
d3d596b09a PICARD-2124: Add and fill _releaseannotation variable 2021-02-22 17:34:09 +01:00
Philipp Wolfer
dee1ad5c81 PICARD-1998: Add "director" (for videos) tag 
This adds a tag "director" which is filled with the "video director" AR from MB by default.
 2021-01-16 15:48:53 +01:00
Philipp Wolfer
4807b34c86 PICARD-204: Rename original release date variables 
Use %_recording_firstreleasedate% and `%_releasegroup_firstreleasedate% for better readability.
 2021-01-15 17:23:57 +01:00
Philipp Wolfer
a7e0b9f999 PICARD-204: Support for recording-level original release date 
Provide variables %_recordingoriginaldate% and %_releaseoriginaldate%.
 2021-01-15 17:23:57 +01:00
Philipp Wolfer
c0e6243a13 PICARD-1926: Adjust test cases for new config structure 2020-12-25 12:37:15 +01:00
Philipp Wolfer
69b0d0e073 PICARD-1961: Keep instrument and other attributes spelling as is 
This was introduced very eraly in d923c9a. Originally MB provided a more fixed list of instruments, with instrument names as attributes actually being camel cased.

This is no longer the case and instruments should now be used as given in the API response.
 2020-10-05 10:43:52 +02:00
dukeyin
cbc1bce030 Add unit test for "Use release relationships" 
* Added a release-level producer to release.json because the existing release-artist relationships are not used in tagging
* Modified the existing release test to check that the producer tag is the release-level producer when "Use release relationships" is enabled
* Added a release test to check that the producer tag is empty when "Use release relationships" is disabled
 2020-07-17 20:01:37 -04:00
dukeyin
f042928433 Don't use release relationships if they are disabled in metadata options 2020-07-17 19:57:37 -04:00
Philipp Wolfer
3f9ad5a743 PICARD-1884: Fix tracknumber tag with value 0 not set 2020-07-14 17:03:30 +00:00
Philipp Wolfer
149e02c914 PICARD-1840: For instrumental recordings unset lyricist 
Also set language to zxx ("No lyrics"), fixes PICARD-1117
 2020-06-17 21:34:02 +02:00
Philipp Wolfer
ac91895629 PICARD-1803: Fixed decamelcasing relationship attributes 
EWI must not become E W I
 2020-04-17 22:02:10 +02:00
Laurent Monin
6b5e852a60 Run fix-header on *.py 2020-02-24 10:25:09 +01:00
Philipp Wolfer
800f61e6b6 PICARD-1752: Use the first matching preferred release country 
For releases with multiple release countries use the first matching preferred release country for %releasecountry%.
 2020-02-19 21:55:23 +00:00
Philipp Wolfer
7539d8dc23 PICARD-1751: Provide a ~releasecountries variable 2020-02-19 21:55:23 +00:00
Philipp Wolfer
4f684d0a48 PICARD-1678: Fix Picard crashing on non-integer search scores 
If the search scores returned by the server are not integer values Picard crashed during metadata comparisson.
 2019-11-29 17:00:59 +01:00
Philipp Wolfer
05ffd72884 tests: use assertIn and assertNotIn 2019-09-13 22:09:36 +02:00
Philipp Wolfer
dc0ec84401 isort: Consistently use two blank lines after import 2019-04-04 08:35:23 +02:00
Philipp Wolfer
dd4da2aa47 Updated isort config to put test imports in separate section 2019-04-04 08:32:22 +02:00
Laurent Monin
c80ae1344b Name countries-related tests, classes and variables consistently 2019-03-25 14:40:52 +01:00
Laurent Monin
a458bbe2ff country_list_from_node() -> countries_from_node() 2019-03-25 14:38:51 +01:00
Laurent Monin
5ae92454f4 Add a test for release without events vs countries 2019-03-25 14:36:56 +01:00
Philipp Wolfer
14277c18b5 PICARD-1288: Added unit tests 2019-02-20 12:55:33 +01:00
Philipp Wolfer
93f38db1b9 PICARD-1395: Rename genre related methods in DataObj 2018-11-25 17:08:49 +01:00
Philipp Wolfer
5988bd66ad PICARD-1395: Load MusicBrainz genres 2018-11-25 17:08:49 +01:00
Wieland Hoffmann
e624aa121c Make PicardTestCase the parent class of all tests 
This brings the faketagger and, more importantly, settings reset to all of them.
 2018-10-23 17:32:50 +02:00
Wieland Hoffmann
624ba7ff7d Always assign config.setting to a copy of the tests settings dictionary 
This prevents any setting from leaking between tests.
 2018-10-23 17:32:50 +02:00
Wieland Hoffmann
dac50a94b3 test_mbjson: Extract self.init_test calls to MBJSONTests setUp() 
This is similar to how test_formats does it. It also means that all tests can
inherit setUp() and don't have to super()-call it.
 2018-10-23 17:32:50 +02:00
Philipp Wolfer
3da76f97ae PICARD-1354: Adressed code review comments 2018-09-25 15:43:52 +02:00
Philipp Wolfer
96c7f2f082 PICARD-1354: Allow using instruments and vocals as credited 2018-09-25 15:07:33 +02:00